Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issue 1250563004: HydrogenCodeStubs consume stack arguments via descriptor. (Closed)

Created:
5 years, 5 months ago by mvstanton
Modified:
4 years, 7 months ago
Reviewers:
danno
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

HydrogenCodeStubs consume stack arguments via descriptor. All of this is controlled by the CallDescriptor. It's simply the case that if you specify less registers than the function arity calls for, the rest are assumed to be on the stack. Bailout handlers accept these constant stack arguments too. BUG= Committed: https://crrev.com/3334b830a512eda1f8eed678a0e6fda52b23472a Cr-Commit-Position: refs/heads/master@{#29813}

Patch Set 1 #

Patch Set 2 : Removed arguments mode as redundant. #

Patch Set 3 : Implemented x64, which uses a register for the map. #

Patch Set 4 : All ports. #

Patch Set 5 : Fix compilation issue. #

Patch Set 6 : Stack arg is behind --vector-stores flag. #

Patch Set 7 : REBASE. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+211 lines, -66 lines) Patch
M src/arm/code-stubs-arm.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M src/arm/interface-descriptors-arm.cc View 1 2 3 4 5 6 1 chunk +8 lines, -0 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 2 3 4 5 6 1 chunk +8 lines, -0 lines 0 comments Download
M src/code-stubs.h View 1 2 3 4 5 6 6 chunks +15 lines, -6 lines 0 comments Download
M src/code-stubs.cc View 1 2 3 4 5 6 3 chunks +1 line, -5 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 2 3 4 5 6 4 chunks +14 lines, -5 lines 0 comments Download
M src/deoptimizer.cc View 1 2 3 4 5 6 5 chunks +23 lines, -5 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 2 3 4 5 6 2 chunks +17 lines, -1 line 0 comments Download
M src/ic/arm/handler-compiler-arm.cc View 1 2 3 4 1 chunk +7 lines, -1 line 0 comments Download
M src/ic/arm64/handler-compiler-arm64.cc View 1 2 3 4 1 chunk +7 lines, -1 line 0 comments Download
M src/ic/handler-compiler.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/ic/handler-compiler.cc View 1 2 3 4 5 6 2 chunks +12 lines, -3 lines 0 comments Download
M src/ic/ia32/handler-compiler-ia32.cc View 1 2 3 1 chunk +10 lines, -1 line 0 comments Download
M src/ic/ic.cc View 1 2 3 4 5 6 1 chunk +5 lines, -1 line 0 comments Download
M src/ic/mips/handler-compiler-mips.cc View 1 2 3 4 1 chunk +7 lines, -1 line 0 comments Download
M src/ic/mips64/handler-compiler-mips64.cc View 1 2 3 4 1 chunk +7 lines, -1 line 0 comments Download
M src/ic/x64/handler-compiler-x64.cc View 1 2 3 4 1 chunk +7 lines, -1 line 0 comments Download
M src/interface-descriptors.h View 1 2 3 4 5 6 8 chunks +13 lines, -14 lines 0 comments Download
M src/interface-descriptors.cc View 1 2 3 4 5 6 2 chunks +11 lines, -6 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 1 2 3 4 5 6 1 chunk +8 lines, -0 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 1 2 3 4 5 6 1 chunk +8 lines, -0 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 2 3 4 5 6 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
mvstanton
Hi Danno, Here is the enhancement we discussed. The other platforms will look like x64, ...
5 years, 5 months ago (2015-07-21 12:43:50 UTC) #2
mvstanton
ping.
5 years, 5 months ago (2015-07-23 07:02:32 UTC) #3
danno
On 2015/07/23 at 07:02:32, mvstanton wrote: > ping. Sorry for the long review, I didn't ...
5 years, 5 months ago (2015-07-23 13:13:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1250563004/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1250563004/120001
5 years, 5 months ago (2015-07-23 13:34:59 UTC) #7
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years, 5 months ago (2015-07-23 14:00:06 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-23 14:00:26 UTC) #9
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/3334b830a512eda1f8eed678a0e6fda52b23472a
Cr-Commit-Position: refs/heads/master@{#29813}

Powered by Google App Engine
This is Rietveld 408576698