Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(965)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/cocoa/panels/panel_window_controller_cocoa.mm

Issue 1250533003: [Mac] Remove BrowserCommandExecutor protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Don't take a window for handleExtraKeyboardShortcut. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/ui/cocoa/chrome_event_processing_window.mm ('K') | « chrome/browser/ui/cocoa/chrome_event_processing_window_unittest.mm ('k') | chrome/browser/ui/cocoa/web_dialog_window_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/panels/panel_window_controller_cocoa.mm
diff --git a/chrome/browser/ui/cocoa/panels/panel_window_controller_cocoa.mm b/chrome/browser/ui/cocoa/panels/panel_window_controller_cocoa.mm
index 7815bdc876cab9b7634ece3d6e254adb29211497..de949486869ba5a5b0b55d90ce4f7fccf7d6f06b 100644
--- a/chrome/browser/ui/cocoa/panels/panel_window_controller_cocoa.mm
+++ b/chrome/browser/ui/cocoa/panels/panel_window_controller_cocoa.mm
@@ -16,7 +16,6 @@
#include "chrome/app/chrome_command_ids.h" // IDC_*
#include "chrome/browser/chrome_browser_application_mac.h"
#include "chrome/browser/profiles/profile.h"
-#import "chrome/browser/ui/cocoa/browser_command_executor.h"
#import "chrome/browser/ui/cocoa/browser_window_utils.h"
#import "chrome/browser/ui/cocoa/panels/mouse_drag_controller.h"
#import "chrome/browser/ui/cocoa/panels/panel_cocoa.h"
@@ -149,23 +148,6 @@ const double kWidthOfMouseResizeArea = 15.0;
}
@end
-// ChromeEventProcessingWindow expects its controller to implement the
-// BrowserCommandExecutor protocol.
-@interface PanelWindowControllerCocoa (InternalAPI) <BrowserCommandExecutor>
-
-// BrowserCommandExecutor methods.
-- (void)executeCommand:(int)command;
-
-@end
-
-@implementation PanelWindowControllerCocoa (InternalAPI)
-
-// This gets called whenever a browser-specific keyboard shortcut is performed
-// in the Panel window. We simply swallow all those events.
-- (void)executeCommand:(int)command {}
-
-@end
-
@implementation PanelWindowControllerCocoa
- (id)initWithPanel:(PanelCocoa*)window {
« chrome/browser/ui/cocoa/chrome_event_processing_window.mm ('K') | « chrome/browser/ui/cocoa/chrome_event_processing_window_unittest.mm ('k') | chrome/browser/ui/cocoa/web_dialog_window_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698