|
[Mac] Remove BrowserCommandExecutor protocol.
Only BrowserWindowController implements this. Other implementors just
turn it into a no-op. ChromeEventProcessingWindow (CEPW) now simply
checks whether it's a Browser window and executes the command.
This is the first step to factor out keyboard shortcut handling in CEPW into
a component that can be reused in Views as it removes one (of two)
dependencies on -[NSWindow windowController], which cannot be used
to implement browser-side behavior under Views.
Added new browser_test for shortcuts in global_keyboard_shortcuts_mac.
Some history:
BrowserCommandExecutor was added in r30619 (6 years ago) to allow a
non-browser window to execute browser commands, but became obsolete
a month later in r32445 when HtmlDialogWindowController (now
WebDialogWindowController) decided to ignore those commands instead.
BUG= 508438
Committed: https://crrev.com/06c25a9881b76f7e0b0ab27050d8c470fe9bdc2d
Cr-Commit-Position: refs/heads/master@{#341062}
Total comments: 14
Total comments: 4
Total comments: 2
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+146 lines, -280 lines) |
Patch |
|
M |
chrome/browser/global_keyboard_shortcuts_mac.h
|
View
|
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/global_keyboard_shortcuts_mac.mm
|
View
|
|
1 chunk |
+2 lines, -3 lines |
0 comments
|
Download
|
|
A |
chrome/browser/global_keyboard_shortcuts_mac_browsertest.mm
|
View
|
1
2
3
4
5
|
1 chunk |
+45 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/cocoa/apps/native_app_window_cocoa.h
|
View
|
|
2 chunks |
+1 line, -4 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm
|
View
|
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
|
D |
chrome/browser/ui/cocoa/browser_command_executor.h
|
View
|
|
1 chunk |
+0 lines, -15 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/cocoa/browser_window_controller.h
|
View
|
1
|
3 chunks |
+0 lines, -7 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/cocoa/browser_window_controller.mm
|
View
|
1
|
1 chunk |
+0 lines, -6 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/cocoa/browser_window_utils.mm
|
View
|
1
2
3
|
1 chunk |
+1 line, -7 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/cocoa/chrome_event_processing_window.h
|
View
|
1
2
3
|
1 chunk |
+4 lines, -13 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/cocoa/chrome_event_processing_window.mm
|
View
|
1
2
3
4
|
5 chunks |
+88 lines, -80 lines |
0 comments
|
Download
|
|
D |
chrome/browser/ui/cocoa/chrome_event_processing_window_unittest.mm
|
View
|
|
1 chunk |
+0 lines, -103 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/cocoa/panels/panel_window_controller_cocoa.mm
|
View
|
1
|
2 chunks |
+0 lines, -18 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/cocoa/web_dialog_window_controller.mm
|
View
|
|
3 chunks |
+0 lines, -18 lines |
0 comments
|
Download
|
|
M |
chrome/chrome_browser_ui.gypi
|
View
|
1
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/chrome_tests.gypi
|
View
|
1
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
chrome/chrome_tests_unit.gypi
|
View
|
1
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
Dependent Patchsets:
Total messages: 18 (4 generated)
|