[Sync] Don't require keystore migration time to be set in nigori node

[Sync] Don't require keystore migration time to be set in nigori node

The condition wasn't necessary, and can cause problems if server created
nodes don't set the time properly.

BUG=512197
Committed: https://crrev.com/dd3f22df2018a2c79903340d49b96ab312663a81
Cr-Commit-Position: refs/heads/master@{#339735}

[Nicolas Zea, 2015-07-21 00:31:28]

zea@chromium.org changed reviewers:
+ pavely@chromium.org

[Nicolas Zea, 2015-07-21 00:31:28]

PTAL

[pavely, 2015-07-21 18:08:46]

lgtm with two comments.

https://codereview.chromium.org/1250503002/diff/20001/sync/internal_api/sync_...
File sync/internal_api/sync_encryption_handler_impl.cc (left):

https://codereview.chromium.org/1250503002/diff/20001/sync/internal_api/sync_...
sync/internal_api/sync_encryption_handler_impl.cc:74: // 2. Migration time is
set.
Item 2. from comment should be removed too.

https://codereview.chromium.org/1250503002/diff/20001/sync/internal_api/sync_...
sync/internal_api/sync_encryption_handler_impl.cc:900: migration_time_ =
ProtoTimeToTime(nigori.keystore_migration_time());
Do we use migration_time_ anywhere other than displaying it in about:sync?
With this change migration_time_ might be null.

[Nicolas Zea, 2015-07-21 19:41:26]

Done, thanks for the review!

https://codereview.chromium.org/1250503002/diff/20001/sync/internal_api/sync_...
File sync/internal_api/sync_encryption_handler_impl.cc (left):

https://codereview.chromium.org/1250503002/diff/20001/sync/internal_api/sync_...
sync/internal_api/sync_encryption_handler_impl.cc:74: // 2. Migration time is
set.
On 2015/07/21 18:08:46, pavely wrote:
> Item 2. from comment should be removed too.

Done.

https://codereview.chromium.org/1250503002/diff/20001/sync/internal_api/sync_...
sync/internal_api/sync_encryption_handler_impl.cc:900: migration_time_ =
ProtoTimeToTime(nigori.keystore_migration_time());
On 2015/07/21 18:08:46, pavely wrote:
> Do we use migration_time_ anywhere other than displaying it in about:sync?
> With this change migration_time_ might be null.

It's only in about:sync. And yeah, I'm okay with it being null there.

[Nicolas Zea, 2015-07-21 19:41:28]

The CQ bit was checked by zea@chromium.org

[Nicolas Zea, 2015-07-21 19:41:28]

The patchset sent to the CQ was uploaded after l-g-t-m from pavely@chromium.org
Link to the patchset: https://codereview.chromium.org/1250503002/#ps40001
(title: "Address comment")

[commit-bot: I haz the power, 2015-07-21 19:41:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1250503002/40001

[commit-bot: I haz the power, 2015-07-21 20:26:42]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-07-21 20:28:51]

Patchset 3 (id:??) landed as
https://crrev.com/dd3f22df2018a2c79903340d49b96ab312663a81
Cr-Commit-Position: refs/heads/master@{#339735}