Store rotation/ui scale to local state.

- Store rotation/ui scale to local state.
- Reset the overscan to the default value if the display has overscan.
- Move overscan data into kDisplayProperties dictionary value.
- Remove Rotate/Scale shortcut from login screen as we can't store the state in login screen.

BUG=196818
TEST=covered by unit test.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189910

[oshima, 2013-03-21 22:42:21]

I'm working on more tests but change itself is ready for review. PTL.

[Jun Mukai, 2013-03-22 00:53:06]

https://codereview.chromium.org/12505005/diff/14047/ash/display/display_chang...
File ash/display/display_change_observer_x11.cc (right):

https://codereview.chromium.org/12505005/diff/14047/ash/display/display_chang...
ash/display/display_change_observer_x11.cc:201:
displays.back().set_ui_scale(0.0f);
setting a scale to '0' sounds awful to me. Why not 1.0f?

https://codereview.chromium.org/12505005/diff/14047/chrome/browser/chromeos/d...
File chrome/browser/chromeos/display/overscan_calibrator.cc (right):

https://codereview.chromium.org/12505005/diff/14047/chrome/browser/chromeos/d...
chrome/browser/chromeos/display/overscan_calibrator.cc:106: if (insets_ ==
native_insets_) {
Can we move this logic to the display controller?
This sounds generic to overscan itself, not specific to the calibration UI.

[oshima, 2013-03-22 02:06:51]

https://codereview.chromium.org/12505005/diff/14047/ash/display/display_chang...
File ash/display/display_change_observer_x11.cc (right):

https://codereview.chromium.org/12505005/diff/14047/ash/display/display_chang...
ash/display/display_change_observer_x11.cc:201:
displays.back().set_ui_scale(0.0f);
On 2013/03/22 00:53:07, Jun Mukai wrote:
> setting a scale to '0' sounds awful to me. Why not 1.0f?

because 1.0f is valid scale. I understand that this may be confusing a bit. I
made it explicit flag.

https://codereview.chromium.org/12505005/diff/14047/chrome/browser/chromeos/d...
File chrome/browser/chromeos/display/overscan_calibrator.cc (right):

https://codereview.chromium.org/12505005/diff/14047/chrome/browser/chromeos/d...
chrome/browser/chromeos/display/overscan_calibrator.cc:106: if (insets_ ==
native_insets_) {
On 2013/03/22 00:53:07, Jun Mukai wrote:
> Can we move this logic to the display controller?
> This sounds generic to overscan itself, not specific to the calibration UI.

I think this is specific to calibration UI. There is a difference between
clearing
and setting, and the custom insets is supposed to override native insets when
specified. If you set the insets, then it should be saved instead of ignoring
it.

[Jun Mukai, 2013-03-22 02:57:17]

lgtm

https://codereview.chromium.org/12505005/diff/8023/chrome/browser/chromeos/di...
File chrome/browser/chromeos/display/overscan_calibrator.cc (right):

https://codereview.chromium.org/12505005/diff/8023/chrome/browser/chromeos/di...
chrome/browser/chromeos/display/overscan_calibrator.cc:117: if
(!native_insets_.empty()) {
braces are unnecessary

[oshima, 2013-03-22 11:36:56]

https://codereview.chromium.org/12505005/diff/8023/chrome/browser/chromeos/di...
File chrome/browser/chromeos/display/overscan_calibrator.cc (right):

https://codereview.chromium.org/12505005/diff/8023/chrome/browser/chromeos/di...
chrome/browser/chromeos/display/overscan_calibrator.cc:117: if
(!native_insets_.empty()) {
On 2013/03/22 02:57:17, Jun Mukai wrote:
> braces are unnecessary

Done.

[oshima, 2013-03-22 12:28:37]

updated test.

jamescook -> ash

[oshima, 2013-03-22 13:05:43]

jamescook -> ash

[James Cook, 2013-03-22 16:53:14]

LGTM if comments addressed

https://codereview.chromium.org/12505005/diff/19003/ash/display/display_contr...
File ash/display/display_controller.cc (right):

https://codereview.chromium.org/12505005/diff/19003/ash/display/display_contr...
ash/display/display_controller.cc:51:
DEFINE_WINDOW_PROPERTY_KEY(gfx::Display::Rotation, kRotationPropKey,
kRotationPropertyKey please

https://codereview.chromium.org/12505005/diff/19003/ash/display/display_contr...
File ash/display/display_controller.h (right):

https://codereview.chromium.org/12505005/diff/19003/ash/display/display_contr...
ash/display/display_controller.h:170: // OBSOLETE
Did you mean to keep this?  Should it be a TODO(oshima): Remove this after ....

https://codereview.chromium.org/12505005/diff/19003/ash/display/display_manag...
File ash/display/display_manager.h (right):

https://codereview.chromium.org/12505005/diff/19003/ash/display/display_manag...
ash/display/display_manager.h:47: // Returns next valud ui scales.
"Returns next valid UI scale."

https://codereview.chromium.org/12505005/diff/19003/chrome/browser/chromeos/d...
File chrome/browser/chromeos/display/overscan_calibrator.h (right):

https://codereview.chromium.org/12505005/diff/19003/chrome/browser/chromeos/d...
chrome/browser/chromeos/display/overscan_calibrator.h:34: // value. Otherwise,
the default value is the old |initial_insets|.
initial_insets -> initial_insets_

[oshima, 2013-03-22 18:20:42]

https://codereview.chromium.org/12505005/diff/19003/ash/display/display_contr...
File ash/display/display_controller.cc (right):

https://codereview.chromium.org/12505005/diff/19003/ash/display/display_contr...
ash/display/display_controller.cc:51:
DEFINE_WINDOW_PROPERTY_KEY(gfx::Display::Rotation, kRotationPropKey,
On 2013/03/22 16:53:14, James Cook (Chromium) wrote:
> kRotationPropertyKey please

Done.

https://codereview.chromium.org/12505005/diff/19003/ash/display/display_contr...
File ash/display/display_controller.h (right):

https://codereview.chromium.org/12505005/diff/19003/ash/display/display_contr...
ash/display/display_controller.h:170: // OBSOLETE
On 2013/03/22 16:53:14, James Cook (Chromium) wrote:
> Did you mean to keep this?  Should it be a TODO(oshima): Remove this after
....

Done.

https://codereview.chromium.org/12505005/diff/19003/ash/display/display_manag...
File ash/display/display_manager.h (right):

https://codereview.chromium.org/12505005/diff/19003/ash/display/display_manag...
ash/display/display_manager.h:47: // Returns next valud ui scales.
On 2013/03/22 16:53:14, James Cook (Chromium) wrote:
> "Returns next valid UI scale."

Done.

https://codereview.chromium.org/12505005/diff/19003/chrome/browser/chromeos/d...
File chrome/browser/chromeos/display/overscan_calibrator.h (right):

https://codereview.chromium.org/12505005/diff/19003/chrome/browser/chromeos/d...
chrome/browser/chromeos/display/overscan_calibrator.h:34: // value. Otherwise,
the default value is the old |initial_insets|.
On 2013/03/22 16:53:14, James Cook (Chromium) wrote:
> initial_insets -> initial_insets_

Done.

[commit-bot: I haz the power, 2013-03-22 19:45:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/12505005/21002

[oshima, 2013-03-22 21:12:31]

On 2013/03/22 19:45:21, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
> https://chromium-status.appspot.com/cq/oshima%40chromium.org/12505005/21002

linux_chromeos,linux_chromeos_clang are green. one failure in win7_aura is
flake, and other bots looks fine. I'm committing manually.

[oshima, 2013-03-22 21:14:04]

Committed patchset #7 manually as r189910 (presubmit successful).