Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issue 1250473002: Fix content verifier problem with content scripts (reland) (Closed)

Created:
5 years, 5 months ago by asargent_no_longer_on_chrome
Modified:
5 years, 4 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix content verifier problem with content scripts (reland) The problem is that we were creating the ContentVerifier too late in ExtensionSystemImpl::Shared::Init, after the script loader had already tried grabbing a reference to it for use on another thead. Therefore at run time, for all content scripts we were was seeing a null pointer for the content verifier and skipping verification of those scripts. Note: this is a reland of https://codereview.chromium.org/1226163010/ which was reverted in b9e8b50e4c45d8aefacac58e28c50d83bb257b7b due to test failures on the Vista Tests bot. BUG=509130 Committed: https://crrev.com/678123d286ab15d26064122c33f88a9d43673392 Cr-Commit-Position: refs/heads/master@{#341435}

Patch Set 1 : Original version of CL #

Patch Set 2 : added extra logging to perhaps get more info from try servers on failures #

Patch Set 3 : fix compile errors #

Patch Set 4 : removed logging and reworked test to elimnate flakiness #

Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -53 lines) Patch
M chrome/browser/extensions/content_verifier_browsertest.cc View 1 2 3 7 chunks +163 lines, -36 lines 0 comments Download
M chrome/browser/extensions/extension_browsertest.cc View 1 chunk +3 lines, -9 lines 0 comments Download
M chrome/browser/extensions/extension_system_impl.cc View 2 chunks +3 lines, -2 lines 0 comments Download
A chrome/test/data/extensions/content_verifier/content_script.crx View Binary file 0 comments Download
M extensions/browser/content_verifier.h View 1 chunk +7 lines, -0 lines 0 comments Download
M extensions/browser/content_verifier.cc View 2 chunks +14 lines, -0 lines 0 comments Download
M extensions/browser/content_verify_job.cc View 2 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
asargent_no_longer_on_chrome
rockot: this is the same CL you reviewed a while ago, with a couple small ...
5 years, 4 months ago (2015-07-31 20:18:35 UTC) #3
Ken Rockot(use gerrit already)
lgtm
5 years, 4 months ago (2015-07-31 22:40:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1250473002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1250473002/80001
5 years, 4 months ago (2015-07-31 22:55:28 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:80001)
5 years, 4 months ago (2015-07-31 23:24:18 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-07-31 23:24:50 UTC) #8
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/678123d286ab15d26064122c33f88a9d43673392
Cr-Commit-Position: refs/heads/master@{#341435}

Powered by Google App Engine
This is Rietveld 408576698