runtime/vm/object.h - Issue 1250463004: Migrate NoSafepointScope; add constrained concurrent allocation to unit test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/object.h

Issue 1250463004: Migrate NoSafepointScope; add constrained concurrent allocation to unit test (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Assert current thread is mutator; add shared assertion macro. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/object.h

diff --git a/runtime/vm/object.h b/runtime/vm/object.h

index b259aace91f16999c855816517e56f68c8c5f363..788b6c1d19d66bfb8a4dae7da65899f592de7922 100644

--- a/runtime/vm/object.h

+++ b/runtime/vm/object.h

@@ -684,7 +684,7 @@ class Object {

ASSERT(Contains(reinterpret_cast<uword>(addr) - 1) &&

Contains(reinterpret_cast<uword>(addr) - kWordSize));

// At least check that there is a NoSafepointScope and hope it's big enough.

- ASSERT(Isolate::Current()->no_safepoint_scope_depth() > 0);

+ ASSERT(Thread::Current()->no_safepoint_scope_depth() > 0);

return const_cast<FieldType*>(addr);

}

« no previous file with comments | « runtime/vm/heap_test.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »