services/http_server/http_server_factory_impl.h - Issue 1250463002: Renames WeakBindingSet to BindingSet.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/http_server/http_server_factory_impl.h

Issue 1250463002: Renames WeakBindingSet to BindingSet. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Fixes test name to be canonical. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: services/http_server/http_server_factory_impl.h

diff --git a/services/http_server/http_server_factory_impl.h b/services/http_server/http_server_factory_impl.h

index 849c6600842cc39c2af31715c81b292c1e2fae73..0923b044dee5cd259a842f5a61d49fabf1f36055 100644

--- a/services/http_server/http_server_factory_impl.h

+++ b/services/http_server/http_server_factory_impl.h

@@ -10,7 +10,7 @@

#include <set>

#include <vector>

-#include "mojo/common/weak_binding_set.h"

+#include "mojo/common/binding_set.h"

#include "mojo/public/cpp/bindings/interface_request.h"

#include "mojo/services/http_server/public/interfaces/http_server_factory.mojom.h"

#include "mojo/services/network/public/interfaces/net_address.mojom.h"

@@ -46,7 +46,7 @@ class HttpServerFactoryImpl : public HttpServerFactory {

void CreateHttpServer(mojo::InterfaceRequest<HttpServer> server_request,

mojo::NetAddressPtr local_address) override;

- mojo::WeakBindingSet<HttpServerFactory> bindings_;

+ mojo::BindingSet<HttpServerFactory> bindings_;

std::map<ServerKey, HttpServerImpl*> port_indicated_servers_;