examples/notification_generator/notification_generator.cc - Issue 1250463002: Renames WeakBindingSet to BindingSet.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: examples/notification_generator/notification_generator.cc

Issue 1250463002: Renames WeakBindingSet to BindingSet. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Fixes test name to be canonical. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: examples/notification_generator/notification_generator.cc

diff --git a/examples/notification_generator/notification_generator.cc b/examples/notification_generator/notification_generator.cc

index e86b2654435e2a9e0c9cd0d0990827417084e929..11d255681bcc7f844a72cab27c377276c9abd682 100644

--- a/examples/notification_generator/notification_generator.cc

+++ b/examples/notification_generator/notification_generator.cc

@@ -5,7 +5,7 @@

#include "base/bind.h"

#include "base/macros.h"

#include "mojo/application/application_runner_chromium.h"

-#include "mojo/common/weak_binding_set.h"

+#include "mojo/common/binding_set.h"

#include "mojo/public/c/system/main.h"

#include "mojo/public/cpp/application/application_delegate.h"

#include "mojo/public/cpp/application/application_impl.h"

@@ -106,7 +106,7 @@ class NotificationGeneratorDelegate : public mojo::ApplicationDelegate,

private:

notifications::NotificationServicePtr notification_service_;

- mojo::WeakBindingSet<notifications::NotificationClient> client_bindings_;

+ mojo::BindingSet<notifications::NotificationClient> client_bindings_;

notifications::NotificationPtr first_notification_;

notifications::NotificationPtr second_notification_;

notifications::NotificationPtr dismissed_notification_;