Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1250463002: Renames WeakBindingSet to BindingSet. (Closed)

Created:
5 years, 5 months ago by rudominer
Modified:
5 years, 5 months ago
Reviewers:
viettrungluu
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fixes order of includes. #

Patch Set 3 : Adds forgotten new files. #

Patch Set 4 : Fixes test name to be canonical. #

Total comments: 4

Patch Set 5 : Remove unneeded includes. #

Patch Set 6 : Rebasing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -209 lines) Patch
M apps/moterm/moterm_view.h View 2 chunks +2 lines, -2 lines 0 comments Download
M examples/echo/echo_server.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M examples/echo_terminal/main.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M examples/nfc_sender/nfc_sender.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M examples/notification_generator/notification_generator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M examples/window_manager/window_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M examples/wm_flow/app/app.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/common/BUILD.gn View 3 chunks +2 lines, -2 lines 0 comments Download
A + mojo/common/binding_set.h View 1 2 3 chunks +8 lines, -10 lines 0 comments Download
A + mojo/common/binding_set_unittest.cc View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
D mojo/common/weak_binding_set.h View 1 chunk +0 lines, -54 lines 0 comments Download
D mojo/common/weak_binding_set_unittest.cc View 1 chunk +0 lines, -108 lines 0 comments Download
M services/authentication/dummy_authentication_app.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M services/device_info/device_info.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M services/http_server/http_server_factory_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M services/http_server/http_server_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M services/icu_data/icu_data_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M services/kiosk_wm/navigator_host_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M services/reaper/reaper_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M services/surfaces/surfaces_impl.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M services/tracing/tracing_app.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
rudominer
Hi Trung, ptal.
5 years, 5 months ago (2015-07-20 23:57:47 UTC) #2
rudominer
New patchset: Fixes test name to be canonical.
5 years, 5 months ago (2015-07-21 00:01:06 UTC) #3
viettrungluu
lgtm w/nits https://codereview.chromium.org/1250463002/diff/60001/services/surfaces/surfaces_impl.h File services/surfaces/surfaces_impl.h (right): https://codereview.chromium.org/1250463002/diff/60001/services/surfaces/surfaces_impl.h#newcode11 services/surfaces/surfaces_impl.h:11: #include "mojo/common/binding_set.h" It seems like this may ...
5 years, 5 months ago (2015-07-21 17:51:02 UTC) #4
rudominer
Committed patchset #6 (id:100001) manually as baee08c915892edd38e5751b761dabc613c6c024 (presubmit successful).
5 years, 5 months ago (2015-07-21 18:12:28 UTC) #5
rudominer
5 years, 5 months ago (2015-07-21 18:12:55 UTC) #6
Message was sent while issue was closed. 
done and submitted

https://codereview.chromium.org/1250463002/diff/60001/services/surfaces/surfa...
File services/surfaces/surfaces_impl.h (right):

https://codereview.chromium.org/1250463002/diff/60001/services/surfaces/surfa...
services/surfaces/surfaces_impl.h:11: #include "mojo/common/binding_set.h"
On 2015/07/21 17:51:01, viettrungluu wrote:
> It seems like this may well be a stale #include, which you may be able to just
> delete instead.

Done.

https://codereview.chromium.org/1250463002/diff/60001/services/tracing/tracin...
File services/tracing/tracing_app.h (right):

https://codereview.chromium.org/1250463002/diff/60001/services/tracing/tracin...
services/tracing/tracing_app.h:11: #include "mojo/common/binding_set.h"
On 2015/07/21 17:51:01, viettrungluu wrote:
> "

Done.

Powered by Google App Engine
This is Rietveld 408576698