Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 1250453004: Revert of Base: Make TimeDelta constructors deal with overflow. (Closed)

Created:
5 years, 5 months ago by Denis Kuznetsov (DE-MUC)
Modified:
5 years, 5 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Base: Make TimeDelta constructors deal with overflow. (patchset #2 id:20001 of https://codereview.chromium.org/1229853004/) Reason for revert: Reverting CL: it seems to cause regression in number of static initializers. For details see https://code.google.com/p/chromium/issues/detail?id=512348 Original issue's description: > Base: Make TimeDelta constructors deal with overflow. > > BUG=466445 > > Committed: https://crrev.com/15462e858ebf34721e28a023b0b670c2011183ac > Cr-Commit-Position: refs/heads/master@{#339605} TBR=thakis@chromium.org,rvargas@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=466445 Committed: https://crrev.com/6376f12c5c99b2ea7a34abb37684b2ca07c0a587 Cr-Commit-Position: refs/heads/master@{#339641}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -167 lines) Patch
M base/time/time.h View 5 chunks +22 lines, -18 lines 0 comments Download
M base/time/time.cc View 3 chunks +10 lines, -4 lines 0 comments Download
M base/time/time_unittest.cc View 3 chunks +119 lines, -145 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Denis Kuznetsov (DE-MUC)
Created Revert of Base: Make TimeDelta constructors deal with overflow.
5 years, 5 months ago (2015-07-21 12:31:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1250453004/1
5 years, 5 months ago (2015-07-21 12:32:21 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-21 12:33:04 UTC) #3
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 12:34:08 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6376f12c5c99b2ea7a34abb37684b2ca07c0a587
Cr-Commit-Position: refs/heads/master@{#339641}

Powered by Google App Engine
This is Rietveld 408576698