Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1250433003: Merge to XFA: Remove dead code found by Scythe. (Closed)

Created:
5 years, 5 months ago by Lei Zhang
Modified:
5 years, 5 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Remove dead code found by Scythe. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1249643003 . (cherry picked from commit b05f1fd710496dea44b001bb905fa1c16a39bb28) Committed: https://pdfium.googlesource.com/pdfium/+/d07958fd2d1c4134d865f4ccb056eb925aaa7d2a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -89 lines) Patch
M core/include/fpdfapi/fpdf_pageobj.h View 1 chunk +0 lines, -1 line 0 comments Download
M core/include/fpdfapi/fpdf_serial.h View 2 chunks +0 lines, -4 lines 0 comments Download
M core/include/fxge/fx_dib.h View 2 chunks +0 lines, -2 lines 0 comments Download
M core/include/fxge/fx_font.h View 1 chunk +0 lines, -7 lines 0 comments Download
M core/include/fxge/fx_ge.h View 1 chunk +0 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/render_int.h View 1 chunk +0 lines, -1 line 0 comments Download
M core/src/fpdftext/text_int.h View 1 chunk +0 lines, -8 lines 0 comments Download
M core/src/fpdftext/txtproc.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/codec/codec_int.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/dib/fx_dib_composite.cpp View 1 chunk +0 lines, -36 lines 0 comments Download
M core/src/fxge/ge/fx_ge_text.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M fpdfsdk/include/formfiller/FFL_FormFiller.h View 2 chunks +0 lines, -9 lines 0 comments Download
M fpdfsdk/include/javascript/JS_Define.h View 3 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/include/javascript/JS_Runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M fpdfsdk/include/jsapi/fxjs_v8.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/formfiller/FFL_FormFiller.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Runtime.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M fpdfsdk/src/jsapi/fxjs_v8.cpp View 3 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Tom Sepez
re-running scythe on XFA might find some new dead stuff, probably you were planning this ...
5 years, 5 months ago (2015-07-22 20:44:52 UTC) #1
Tom Sepez
lgtm
5 years, 5 months ago (2015-07-22 20:44:55 UTC) #2
Lei Zhang
On 2015/07/22 20:44:52, Tom Sepez wrote: > re-running scythe on XFA might find some new ...
5 years, 5 months ago (2015-07-22 20:47:44 UTC) #3
Lei Zhang
5 years, 5 months ago (2015-07-22 20:47:54 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
d07958fd2d1c4134d865f4ccb056eb925aaa7d2a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698