Source/bindings/tests/results/V8TestInterfaceCustomConstructor.cpp - Issue 125043004: Remove world type from hasInstance()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/V8TestInterfaceCustomConstructor.cpp

Issue 125043004: Remove world type from hasInstance() (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/V8TestInterfaceCustomConstructor.h ('k') | Source/bindings/tests/results/V8TestInterfaceDoNotCheckConstants.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/V8TestInterfaceCustomConstructor.cpp

diff --git a/Source/bindings/tests/results/V8TestInterfaceCustomConstructor.cpp b/Source/bindings/tests/results/V8TestInterfaceCustomConstructor.cpp

index 7080ee3c921f448297e1529ec1e12a45bb967859..62a3c2bf7fb4655e87bec5129dd35725e48b8fe5 100644

--- a/Source/bindings/tests/results/V8TestInterfaceCustomConstructor.cpp

+++ b/Source/bindings/tests/results/V8TestInterfaceCustomConstructor.cpp

@@ -121,16 +121,10 @@ v8::Handle<v8::FunctionTemplate> V8TestInterfaceCustomConstructor::domTemplate(v

return handleScope.Escape(templ);

}

-bool V8TestInterfaceCustomConstructor::hasInstance(v8::Handle<v8::Value> jsValue, v8::Isolate* isolate, WrapperWorldType currentWorldType)

+bool V8TestInterfaceCustomConstructor::hasInstance(v8::Handle<v8::Value> jsValue, v8::Isolate* isolate)

{

- return V8PerIsolateData::from(isolate)->hasInstance(&wrapperTypeInfo, jsValue, currentWorldType);

-bool V8TestInterfaceCustomConstructor::hasInstanceInAnyWorld(v8::Handle<v8::Value> jsValue, v8::Isolate* isolate)

- return V8PerIsolateData::from(isolate)->hasInstance(&wrapperTypeInfo, jsValue, MainWorld)

- || V8PerIsolateData::from(isolate)->hasInstance(&wrapperTypeInfo, jsValue, IsolatedWorld)

- || V8PerIsolateData::from(isolate)->hasInstance(&wrapperTypeInfo, jsValue, WorkerWorld);

+ return V8PerIsolateData::from(isolate)->hasInstanceInMainWorld(&wrapperTypeInfo, jsValue)

+ || V8PerIsolateData::from(isolate)->hasInstanceInNonMainWorld(&wrapperTypeInfo, jsValue);

}

v8::Handle<v8::Object> V8TestInterfaceCustomConstructor::createWrapper(PassRefPtr<TestInterfaceCustomConstructor> impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)