Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: mojo/devtools/common/devtoolslib/shell_arguments.py

Issue 1250423007: Process --map-origin and --map-url flags regardless of the platform. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/devtools/common/devtoolslib/shell_arguments.py
diff --git a/mojo/devtools/common/devtoolslib/shell_arguments.py b/mojo/devtools/common/devtoolslib/shell_arguments.py
index 7b61194d726eaec36c7560763fc585e4ced025fd..55c22eb1940a7f415e8120529d376f19fe66b374 100644
--- a/mojo/devtools/common/devtoolslib/shell_arguments.py
+++ b/mojo/devtools/common/devtoolslib/shell_arguments.py
@@ -64,7 +64,7 @@ def _rewrite(mapping, host_destination_functon, shell, port):
return src + '=' + dest
-def _apply_appings(shell, original_arguments, map_urls, map_origins):
+def _apply_mappings(shell, original_arguments, map_urls, map_origins):
"""Applies mappings for specified urls and origins. For each local path
specified as destination a local server will be spawned and the mapping will
be rewritten accordingly.
@@ -255,9 +255,6 @@ def configure_shell(config_args, shell_args):
raise ShellConfigurationException('Device check failed: ' + error)
if config_args.shell_path:
shell.InstallApk(config_args.shell_path)
-
- shell_args = _apply_appings(shell, shell_args, config_args.map_url,
- config_args.map_origin)
else:
if not config_args.shell_path:
raise ShellConfigurationException('Can not run without a shell binary. '
@@ -266,6 +263,9 @@ def configure_shell(config_args, shell_args):
if config_args.use_osmesa:
shell_args.append('--args-for=mojo:native_viewport_service --use-osmesa')
+ shell_args = _apply_mappings(shell, shell_args, config_args.map_url,
+ config_args.map_origin)
+
if config_args.origin:
if _is_web_url(config_args.origin):
shell_args.append('--origin=' + config_args.origin)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698