Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1250423002: Find right scope associated with prologue (Closed)

Created:
5 years, 5 months ago by rossberg
Modified:
5 years, 5 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Find right scope associated with prologue R=mstarzinger@chromium.org BUG=513474, 513475, 513611, 513612 LOG=N Committed: https://crrev.com/3e40b64ade382320697a7dffc762afb4d12da095 Cr-Commit-Position: refs/heads/master@{#29845}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -50 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M src/scopes.h View 1 chunk +4 lines, -2 lines 0 comments Download
M src/scopes.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + test/mjsunit/harmony/regress/regress-513474.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
rossberg
5 years, 5 months ago (2015-07-24 12:10:12 UTC) #1
Michael Starzinger
LGTM.
5 years, 5 months ago (2015-07-24 12:43:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1250423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1250423002/1
5 years, 5 months ago (2015-07-24 12:43:33 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-24 13:08:19 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-24 13:08:44 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3e40b64ade382320697a7dffc762afb4d12da095
Cr-Commit-Position: refs/heads/master@{#29845}

Powered by Google App Engine
This is Rietveld 408576698