chrome/browser/ui/cocoa/chrome_event_processing_window.h - Issue 1250403002: [Mac] Move UI item validation to UserInterfaceItemCommandHandler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/chrome_event_processing_window.h

Issue 1250403002: [Mac] Move UI item validation to UserInterfaceItemCommandHandler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@commandexecute

Patch Set: Sync Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/chrome_command_dispatcher_delegate.mm ('K') | « chrome/browser/ui/cocoa/chrome_command_dispatcher_delegate.mm ('k') | chrome/browser/ui/cocoa/chrome_event_processing_window.mm » ('j') | chrome/browser/ui/cocoa/chrome_event_processing_window.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/chrome_event_processing_window.h

diff --git a/chrome/browser/ui/cocoa/chrome_event_processing_window.h b/chrome/browser/ui/cocoa/chrome_event_processing_window.h

index a5f65cb1003ac0e3ad2bfa77c054541d3cd3d358..ffef834c8c38d44d52edc9309df54ccfa424704f 100644

--- a/chrome/browser/ui/cocoa/chrome_event_processing_window.h

+++ b/chrome/browser/ui/cocoa/chrome_event_processing_window.h

@@ -17,7 +17,8 @@

// processing); subclassing NSWindow is the only method to do

// this.

@interface ChromeEventProcessingWindow

- : UnderlayOpenGLHostingWindow<CommandDispatchingWindow>

+ : UnderlayOpenGLHostingWindow<CommandDispatchingWindow,

+ NSUserInterfaceValidations>

tapted 2015/09/03 04:15:38 NSWindow already conforms to NSUserInterfaceValida

jackhou1 2015/09/03 06:15:39 Done.

// Checks if |event| is a window, delayed window, or browser keyboard shortcut.

// (See global_keyboard_shortcuts_mac.h for details). If so, execute the