chrome/browser/ui/cocoa/chrome_command_dispatcher_delegate.h - Issue 1250403002: [Mac] Move UI item validation to UserInterfaceItemCommandHandler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/chrome_command_dispatcher_delegate.h

Issue 1250403002: [Mac] Move UI item validation to UserInterfaceItemCommandHandler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@commandexecute

Patch Set: Sync Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_controller.mm ('k') | chrome/browser/ui/cocoa/chrome_command_dispatcher_delegate.mm » ('j') | chrome/browser/ui/cocoa/chrome_command_dispatcher_delegate.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/chrome_command_dispatcher_delegate.h

diff --git a/chrome/browser/ui/cocoa/chrome_command_dispatcher_delegate.h b/chrome/browser/ui/cocoa/chrome_command_dispatcher_delegate.h

index 17f0d8eccdaf97775e16282fd5f2baedb8c1dfb2..f4347e2b1f17704a89498e5b879f85742734b312 100644

--- a/chrome/browser/ui/cocoa/chrome_command_dispatcher_delegate.h

+++ b/chrome/browser/ui/cocoa/chrome_command_dispatcher_delegate.h

@@ -10,8 +10,11 @@

#import "ui/base/cocoa/command_dispatcher.h"

// Implement CommandDispatcherDelegate by intercepting browser window keyboard

-// shortcuts and executing them with chrome::ExecuteCommand.

-@interface ChromeCommandDispatcherDelegate : NSObject<CommandDispatcherDelegate>

+// shortcuts and executing them with chrome::ExecuteCommand. Implement

+// UserInterfaceItemCommandHandler by validating items using global chrome::

+// functions and executing commands with chrome::ExecuteCommand().

+@interface ChromeCommandDispatcherDelegate

+ : NSObject<CommandDispatcherDelegate, UserInterfaceItemCommandHandler>

// Checks if |event| is a keyboard shortcut listed in

// global_keyboard_shortcuts_mac.h. If so, execute the associated command.