chrome/browser/ui/views/frame/browser_frame_mac.mm - Issue 1250403002: [Mac] Move UI item validation to UserInterfaceItemCommandHandler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_frame_mac.mm

Issue 1250403002: [Mac] Move UI item validation to UserInterfaceItemCommandHandler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@commandexecute

Patch Set: Split out BrowserWindowCommandHandler and only use it in browser windows. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/browser_window_controller.mm ('K') | « chrome/browser/ui/views/frame/browser_frame_mac.h ('k') | chrome/chrome_browser_ui.gypi » ('j') | ui/base/cocoa/command_dispatcher.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/frame/browser_frame_mac.mm

diff --git a/chrome/browser/ui/views/frame/browser_frame_mac.mm b/chrome/browser/ui/views/frame/browser_frame_mac.mm

index cd705a40a9a22b67959a34aae7d8dd37a299554f..f9108fa0bd417a946cf7ee060bba63d3de60dcb1 100644

--- a/chrome/browser/ui/views/frame/browser_frame_mac.mm

+++ b/chrome/browser/ui/views/frame/browser_frame_mac.mm

@@ -4,6 +4,7 @@

#include "chrome/browser/ui/views/frame/browser_frame_mac.h"

+#import "chrome/browser/ui/cocoa/browser_window_command_handler.h"

#import "chrome/browser/ui/cocoa/chrome_command_dispatcher_delegate.h"

#include "chrome/browser/ui/views/frame/browser_frame.h"

#include "chrome/browser/ui/views/frame/browser_shutdown.h"

@@ -17,7 +18,8 @@ BrowserFrameMac::BrowserFrameMac(BrowserFrame* browser_frame,

: views::NativeWidgetMac(browser_frame),

browser_view_(browser_view),

command_dispatcher_delegate_(

- [[ChromeCommandDispatcherDelegate alloc] init]) {}

+ [[ChromeCommandDispatcherDelegate alloc] init]),

+ command_handler_([[BrowserWindowCommandHandler alloc] init]) {}

BrowserFrameMac::~BrowserFrameMac() {

}

@@ -70,6 +72,7 @@ NativeWidgetMacNSWindow* BrowserFrameMac::CreateNSWindow(

backing:NSBackingStoreBuffered

defer:NO]);

[ns_window setCommandDispatcherDelegate:command_dispatcher_delegate_];

+ [ns_window setCommandHandler:command_handler_];

return ns_window.autorelease();

}