Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1531)

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller.h

Issue 1250403002: [Mac] Move UI item validation to UserInterfaceItemCommandHandler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@commandexecute
Patch Set: Split out BrowserWindowCommandHandler and only use it in browser windows. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser_window_controller.h
diff --git a/chrome/browser/ui/cocoa/browser_window_controller.h b/chrome/browser/ui/cocoa/browser_window_controller.h
index 0fbbad76f3ae71d6900879b8f32ab444ddeec47e..4303742387ddd8ab6a480a3b514094b94ee7adcc 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller.h
+++ b/chrome/browser/ui/cocoa/browser_window_controller.h
@@ -32,6 +32,7 @@ class BookmarkBubbleObserverCocoa;
class Browser;
class BrowserWindow;
class BrowserWindowCocoa;
+@class BrowserWindowCommandHandler;
@class BrowserWindowFullscreenTransition;
@class DevToolsController;
@class DownloadShelfController;
@@ -58,11 +59,10 @@ namespace extensions {
class Command;
}
-@interface BrowserWindowController :
- TabWindowController<NSUserInterfaceValidations,
- BookmarkBarControllerDelegate,
- ViewResizer,
- TabStripControllerDelegate> {
+@interface BrowserWindowController
+ : TabWindowController<BookmarkBarControllerDelegate,
+ ViewResizer,
+ TabStripControllerDelegate> {
@private
// The ordering of these members is important as it determines the order in
// which they are destroyed. |browser_| needs to be destroyed last as most of
@@ -85,6 +85,7 @@ class Command;
exclusiveAccessBubbleWindowController_;
base::scoped_nsobject<BrowserWindowFullscreenTransition>
fullscreenTransition_;
+ base::scoped_nsobject<BrowserWindowCommandHandler> commandHandler_;
// Strong. StatusBubble is a special case of a strong reference that
// we don't wrap in a scoped_ptr because it is acting the same
@@ -499,9 +500,6 @@ class Command;
// or exit Lion fullscreen mode. Must not be called on Snow Leopard or earlier.
- (void)handleLionToggleFullscreen;
-// The title of the fullscreen menu item in the menu bar.
-- (NSString*)titleForFullscreenMenuItem;
-
// Enters Browser/Appkit Fullscreen.
// If |withToolbar| is NO, the tab strip and toolbar are hidden
// (aka Presentation Mode).

Powered by Google App Engine
This is Rietveld 408576698