Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: webkit/plugins/ppapi/host_var_tracker.cc

Issue 12504007: Revert 186925 since it breaks many of the builds on the bots (e.g. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/plugins/ppapi/host_globals.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/plugins/ppapi/host_var_tracker.cc
===================================================================
--- webkit/plugins/ppapi/host_var_tracker.cc (revision 186938)
+++ webkit/plugins/ppapi/host_var_tracker.cc (working copy)
@@ -16,8 +16,7 @@
namespace webkit {
namespace ppapi {
-HostVarTracker::HostVarTracker()
- : VarTracker(SINGLE_THREADED) {
+HostVarTracker::HostVarTracker() {
}
HostVarTracker::~HostVarTracker() {
@@ -28,7 +27,7 @@
}
void HostVarTracker::AddNPObjectVar(NPObjectVar* object_var) {
- CheckThreadingPreconditions();
+ DCHECK(CalledOnValidThread());
InstanceMap::iterator found_instance = instance_map_.find(
object_var->pp_instance());
@@ -48,7 +47,7 @@
}
void HostVarTracker::RemoveNPObjectVar(NPObjectVar* object_var) {
- CheckThreadingPreconditions();
+ DCHECK(CalledOnValidThread());
InstanceMap::iterator found_instance = instance_map_.find(
object_var->pp_instance());
@@ -73,7 +72,7 @@
NPObjectVar* HostVarTracker::NPObjectVarForNPObject(PP_Instance instance,
NPObject* np_object) {
- CheckThreadingPreconditions();
+ DCHECK(CalledOnValidThread());
InstanceMap::iterator found_instance = instance_map_.find(instance);
if (found_instance == instance_map_.end())
@@ -88,7 +87,7 @@
}
int HostVarTracker::GetLiveNPObjectVarsForInstance(PP_Instance instance) const {
- CheckThreadingPreconditions();
+ DCHECK(CalledOnValidThread());
InstanceMap::const_iterator found = instance_map_.find(instance);
if (found == instance_map_.end())
@@ -97,7 +96,7 @@
}
void HostVarTracker::DidDeleteInstance(PP_Instance instance) {
- CheckThreadingPreconditions();
+ DCHECK(CalledOnValidThread());
InstanceMap::iterator found_instance = instance_map_.find(instance);
if (found_instance == instance_map_.end())
« no previous file with comments | « webkit/plugins/ppapi/host_globals.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698