tests/standalone/io/secure_server_socket_test.dart - Issue 12504006: Make IOSink implement StringSink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/standalone/io/secure_server_socket_test.dart

Issue 12504006: Make IOSink implement StringSink (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Addressed second round of review comments Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/standalone/io/secure_server_socket_test.dart

diff --git a/tests/standalone/io/secure_server_socket_test.dart b/tests/standalone/io/secure_server_socket_test.dart

index c66019a587b8b749d97e640c810961ff60330d2a..ad5f4d377fca5443b3b8a2c240575e9a0049fdeb 100644

--- a/tests/standalone/io/secure_server_socket_test.dart

+++ b/tests/standalone/io/secure_server_socket_test.dart

@@ -170,7 +170,7 @@ void testSimpleReadWrite() {

bytesRead += buffer.length;

if (bytesRead == data.length) {

verifyTestData(data);

- client.add(data);

+ client.writeBytes(data);

client.close();

}

@@ -184,7 +184,7 @@ void testSimpleReadWrite() {

int bytesWritten = 0;

List<int> dataSent = createTestData();

List<int> dataReceived = new List<int>(dataSent.length);

- socket.add(dataSent);

+ socket.writeBytes(dataSent);

socket.close(); // Can also be delayed.

socket.listen(

(List<int> buffer) {