Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Unified Diff: tests/standalone/io/http_server_response_test.dart

Issue 12504006: Make IOSink implement StringSink (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed second round of review comments Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/standalone/io/http_server_response_test.dart
diff --git a/tests/standalone/io/http_server_response_test.dart b/tests/standalone/io/http_server_response_test.dart
index fc948762be0a7f97b2dbbfcd37b76e5c4d7d605d..8cbfaa4396cac5483fa3c60beea6f807717fde0b 100644
--- a/tests/standalone/io/http_server_response_test.dart
+++ b/tests/standalone/io/http_server_response_test.dart
@@ -55,7 +55,7 @@ void testResponseAddStream() {
int bytes = new File(new Options().script).lengthSync();
testServerRequest((server, request) {
- request.response.addStream(new File(new Options().script).openRead())
+ request.response.writeStream(new File(new Options().script).openRead())
.then((response) {
response.close();
response.done.then((_) => server.close());
@@ -63,9 +63,9 @@ void testResponseAddStream() {
}, bytes: bytes);
testServerRequest((server, request) {
- request.response.addStream(new File(new Options().script).openRead())
+ request.response.writeStream(new File(new Options().script).openRead())
.then((response) {
- request.response.addStream(new File(new Options().script).openRead())
+ request.response.writeStream(new File(new Options().script).openRead())
.then((response) {
response.close();
response.done.then((_) => server.close());
@@ -75,7 +75,7 @@ void testResponseAddStream() {
testServerRequest((server, request) {
var controller = new StreamController();
- request.response.addStream(controller.stream)
+ request.response.writeStream(controller.stream)
.then((response) {
response.close();
response.done.then((_) => server.close());
@@ -87,7 +87,7 @@ void testResponseAddStream() {
void testBadResponseAdd() {
testServerRequest((server, request) {
request.response.contentLength = 0;
- request.response.add([0]);
+ request.response.writeBytes([0]);
request.response.done.catchError((error) {
server.close();
}, test: (e) => e is HttpException);
@@ -95,8 +95,8 @@ void testBadResponseAdd() {
testServerRequest((server, request) {
request.response.contentLength = 5;
- request.response.add([0, 0, 0]);
- request.response.add([0, 0, 0]);
+ request.response.writeBytes([0, 0, 0]);
+ request.response.writeBytes([0, 0, 0]);
request.response.done.catchError((error) {
server.close();
}, test: (e) => e is HttpException);
@@ -104,9 +104,9 @@ void testBadResponseAdd() {
testServerRequest((server, request) {
request.response.contentLength = 0;
- request.response.add(new Uint8List(64 * 1024));
- request.response.add(new Uint8List(64 * 1024));
- request.response.add(new Uint8List(64 * 1024));
+ request.response.writeBytes(new Uint8List(64 * 1024));
+ request.response.writeBytes(new Uint8List(64 * 1024));
+ request.response.writeBytes(new Uint8List(64 * 1024));
request.response.done.catchError((error) {
server.close();
}, test: (e) => e is HttpException);
@@ -124,7 +124,7 @@ void testBadResponseClose() {
testServerRequest((server, request) {
request.response.contentLength = 5;
- request.response.add([0]);
+ request.response.writeBytes([0]);
request.response.close();
request.response.done.catchError((error) {
server.close();
« no previous file with comments | « tests/standalone/io/http_server_early_client_close_test.dart ('k') | tests/standalone/io/http_shutdown_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698