Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: tests/standalone/io/http_read_test.dart

Issue 12504006: Make IOSink implement StringSink (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed second round of review comments Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/standalone/io/http_proxy_test.dart ('k') | tests/standalone/io/http_request_pipeling_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/io/http_read_test.dart
diff --git a/tests/standalone/io/http_read_test.dart b/tests/standalone/io/http_read_test.dart
index 6cba2b5108367155f40fa89b8e04b854ed32c8f1..32226c66a1e944fc66ed9546b409723baf4c5656 100644
--- a/tests/standalone/io/http_read_test.dart
+++ b/tests/standalone/io/http_read_test.dart
@@ -111,7 +111,7 @@ class TestServer {
var response = request.response;
response.statusCode = HttpStatus.NOT_FOUND;
response.headers.set("Content-Type", "text/html; charset=UTF-8");
- response.addString("Page not found");
+ response.write("Page not found");
response.close();
}
@@ -170,11 +170,11 @@ void testRead(bool chunkedEncoding) {
httpClient.post("127.0.0.1", port, "/echo")
.then((request) {
if (chunkedEncoding) {
- request.addString(data.substring(0, 10));
- request.addString(data.substring(10, data.length));
+ request.write(data.substring(0, 10));
+ request.write(data.substring(10, data.length));
} else {
request.contentLength = data.length;
- request.add(data.codeUnits);
+ request.writeBytes(data.codeUnits);
}
return request.close();
})
« no previous file with comments | « tests/standalone/io/http_proxy_test.dart ('k') | tests/standalone/io/http_request_pipeling_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698