tests/standalone/io/http_keep_alive_test.dart - Issue 12504006: Make IOSink implement StringSink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/standalone/io/http_keep_alive_test.dart

Issue 12504006: Make IOSink implement StringSink (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Addressed second round of review comments Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/standalone/io/http_keep_alive_test.dart

diff --git a/tests/standalone/io/http_keep_alive_test.dart b/tests/standalone/io/http_keep_alive_test.dart

index c89b4eef96476a766c9023519fe46e709a9e4ae3..30373e8c10681c8a02535953b542d8b7745c680b 100644

--- a/tests/standalone/io/http_keep_alive_test.dart

+++ b/tests/standalone/io/http_keep_alive_test.dart

@@ -28,7 +28,7 @@ Future<HttpServer> startServer() {

int length = int.parse(request.queryParameters["length"]);

var buffer = new List<int>.filled(length, 0);

if (!chunked) request.response.contentLength = length;

- request.response.add(buffer);

+ request.response.writeBytes(buffer);

request.response.close();

});

return server;