Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: tests/standalone/io/http_client_request_test.dart

Issue 12504006: Make IOSink implement StringSink (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed second round of review comments Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/standalone/io/http_client_connect_test.dart ('k') | tests/standalone/io/http_close_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/io/http_client_request_test.dart
diff --git a/tests/standalone/io/http_client_request_test.dart b/tests/standalone/io/http_client_request_test.dart
index 02d0a86ce4a65618f1d5259afe872425a55aecdf..d2c9236c446109448b1e291e164cbac07759cd6d 100644
--- a/tests/standalone/io/http_client_request_test.dart
+++ b/tests/standalone/io/http_client_request_test.dart
@@ -46,7 +46,7 @@ void testBadResponseAdd() {
testClientRequest((request) {
var port = new ReceivePort();
request.contentLength = 0;
- request.add([0]);
+ request.writeBytes([0]);
request.done.catchError((error) {
port.close();
}, test: (e) => e is HttpException);
@@ -56,8 +56,8 @@ void testBadResponseAdd() {
testClientRequest((request) {
var port = new ReceivePort();
request.contentLength = 5;
- request.add([0, 0, 0]);
- request.add([0, 0, 0]);
+ request.writeBytes([0, 0, 0]);
+ request.writeBytes([0, 0, 0]);
request.done.catchError((error) {
port.close();
}, test: (e) => e is HttpException);
@@ -67,9 +67,9 @@ void testBadResponseAdd() {
testClientRequest((request) {
var port = new ReceivePort();
request.contentLength = 0;
- request.add(new Uint8List(64 * 1024));
- request.add(new Uint8List(64 * 1024));
- request.add(new Uint8List(64 * 1024));
+ request.writeBytes(new Uint8List(64 * 1024));
+ request.writeBytes(new Uint8List(64 * 1024));
+ request.writeBytes(new Uint8List(64 * 1024));
request.done.catchError((error) {
port.close();
}, test: (e) => e is HttpException);
@@ -91,7 +91,7 @@ void testBadResponseClose() {
testClientRequest((request) {
var port = new ReceivePort();
request.contentLength = 5;
- request.add([0]);
+ request.writeBytes([0]);
request.close();
request.done.catchError((error) {
port.close();
« no previous file with comments | « tests/standalone/io/http_client_connect_test.dart ('k') | tests/standalone/io/http_close_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698