sdk/lib/io/websocket_impl.dart - Issue 12504006: Make IOSink implement StringSink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/io/websocket_impl.dart

Issue 12504006: Make IOSink implement StringSink (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Addressed second round of review comments Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/io/websocket_impl.dart

diff --git a/sdk/lib/io/websocket_impl.dart b/sdk/lib/io/websocket_impl.dart

index b7ca9a066c4832ad68d853317655f2aa801d3a01..86ee88d71085cf1ed5cd4dc072e775e0ccc9f0d2 100644

--- a/sdk/lib/io/websocket_impl.dart

+++ b/sdk/lib/io/websocket_impl.dart

@@ -659,9 +659,9 @@ class _WebSocketImpl extends Stream implements WebSocket {

}

assert(index == headerSize);

try {

- _socket.add(header);

+ _socket.writeBytes(header);

if (data != null) {

- _socket.add(data);

+ _socket.writeBytes(data);

}

} catch (_) {

// The socket can be closed before _socket.done have a chance

« no previous file with comments | « sdk/lib/io/string_transformer.dart ('k') | tests/standalone/debugger/debug_lib.dart » ('j') | no next file with comments »