Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: tests/standalone/io/socket_invalid_arguments_test.dart

Issue 12504006: Make IOSink implement StringSink (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed second round of review comments Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « tests/standalone/io/socket_exception_test.dart ('k') | tests/standalone/io/socket_test.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import "dart:io"; 5 import "dart:io";
6 import "dart:isolate"; 6 import "dart:isolate";
7 7
8 class NotAnInteger { 8 class NotAnInteger {
9 operator==(other) => other == 1; 9 operator==(other) => other == 1;
10 operator<(other) => other > 1; 10 operator<(other) => other > 1;
(...skipping 21 matching lines...) Expand all
32 socket.listen( 32 socket.listen(
33 (_) { }, 33 (_) { },
34 onError: (error) { 34 onError: (error) {
35 Expect.fail("Error on stream"); 35 Expect.fail("Error on stream");
36 }, 36 },
37 onDone: () { 37 onDone: () {
38 Expect.equals(1, errors); 38 Expect.equals(1, errors);
39 socket.destroy(); 39 socket.destroy();
40 server.close(); 40 server.close();
41 }); 41 });
42 socket.add(buffer); 42 socket.writeBytes(buffer);
43 }); 43 });
44 }); 44 });
45 } 45 }
46 46
47 testServerSocketCreation(address, port, backlog) { 47 testServerSocketCreation(address, port, backlog) {
48 var server; 48 var server;
49 var port = new ReceivePort(); 49 var port = new ReceivePort();
50 try { 50 try {
51 ServerSocket.bind(address, port, backlog) 51 ServerSocket.bind(address, port, backlog)
52 .then((_) { Expect.fail("ServerSocket bound"); }); 52 .then((_) { Expect.fail("ServerSocket bound"); });
(...skipping 11 matching lines...) Expand all
64 testAdd(42); 64 testAdd(42);
65 // TODO(8233): Throw ArgumentError from API implementation. 65 // TODO(8233): Throw ArgumentError from API implementation.
66 // testAdd([-1]); 66 // testAdd([-1]);
67 // testAdd([2222222222222222222222222222222]); 67 // testAdd([2222222222222222222222222222222]);
68 // testAdd([1, 2, 3, null]); 68 // testAdd([1, 2, 3, null]);
69 // testAdd([new NotAnInteger()]); 69 // testAdd([new NotAnInteger()]);
70 testServerSocketCreation(123, 123, 123); 70 testServerSocketCreation(123, 123, 123);
71 testServerSocketCreation("string", null, null); 71 testServerSocketCreation("string", null, null);
72 testServerSocketCreation("string", 123, null); 72 testServerSocketCreation("string", 123, null);
73 } 73 }
OLDNEW
« no previous file with comments | « tests/standalone/io/socket_exception_test.dart ('k') | tests/standalone/io/socket_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698