Make IOSink implement StringSink

tests/standalone/io/http_10_test.dart

-// Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
+// (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // VMOptions=
 // VMOptions=--short_socket_read
 // VMOptions=--short_socket_write
 // VMOptions=--short_socket_read --short_socket_write
 
 import "dart:isolate";
 import "dart:io";
 
 // Client makes a HTTP 1.0 request without connection keep alive. The
 // server sets a content length but still needs to close the
 // connection as there is no keep alive.
 void testHttp10NoKeepAlive() {
   HttpServer.bind().then((server) {
     server.listen(
         (HttpRequest request) {
           Expect.isNull(request.headers.value('content-length'));
           Expect.equals(-1, request.contentLength);
           var response = request.response;
           response.contentLength = 1;
           Expect.equals("1.0", request.protocolVersion);
           response.done
               .then((_) => Expect.fail("Unexpected response completion"))
               .catchError((e) => Expect.isTrue(e.error is HttpException));
-          response.addString("Z");
-          response.addString("Z");
+          response.write("Z");
+          response.write("Z");
           response.close();
-          Expect.throws(() => response.addString("x"),
+          Expect.throws(() => response.write("x"),
                         (e) => e is StateError);
         },
         onError: (e) => Expect.fail("Unexpected error $e"));
 
     int count = 0;
     makeRequest() {
       Socket.connect("127.0.0.1", server.port).then((socket) {
-          socket.addString("GET / HTTP/1.0\r\n\r\n");
+          socket.write("GET / HTTP/1.0\r\n\r\n");
 
           List<int> response = [];
           socket.listen(
               response.addAll,
               onDone: () {
                 count++;
                 socket.destroy();
                 String s = new String.fromCharCodes(response).toLowerCase();
                 Expect.equals("z", s[s.length - 1]);
                 Expect.isTrue(s.indexOf("\r\ncontent-length: 1\r\n") > 0);
@@ skipping 15 matching lines @@
 // content length so it has to close the connection to mark the end of
 // the response.
 void testHttp10ServerClose() {
   HttpServer.bind().then((server) {
     server.listen(
         (HttpRequest request) {
           Expect.isNull(request.headers.value('content-length'));
           Expect.equals(-1, request.contentLength);
           var response = request.response;
           Expect.equals("1.0", request.protocolVersion);
-          response.addString("Z");
+          response.write("Z");
           response.close();
         },
         onError: (e) => Expect.fail("Unexpected error $e"));
 
     int count = 0;
     makeRequest() {
       Socket.connect("127.0.0.1", server.port).then((socket) {
-        socket.addString("GET / HTTP/1.0\r\n\r\n");
-        socket.addString("Connection: Keep-Alive\r\n\r\n");
+        socket.write("GET / HTTP/1.0\r\n\r\n");
+        socket.write("Connection: Keep-Alive\r\n\r\n");
 
         List<int> response = [];
         socket.listen(
             response.addAll,
             onDone: () {
               socket.destroy();
               count++;
               String s = new String.fromCharCodes(response).toLowerCase();
               print(s);
               Expect.equals("z", s[s.length - 1]);
@@ skipping 17 matching lines @@
 // used.
 void testHttp10KeepAlive() {
   HttpServer.bind().then((server) {
     server.listen(
         (HttpRequest request) {
           Expect.isNull(request.headers.value('content-length'));
           Expect.equals(-1, request.contentLength);
           var response = request.response;
           response.contentLength = 1;
           Expect.equals("1.0", request.protocolVersion);
-          response.addString("Z");
+          response.write("Z");
           response.close();
         },
         onError: (e) => Expect.fail("Unexpected error $e"));
 
     Socket.connect("127.0.0.1", server.port).then((socket) {
       void sendRequest() {
-        socket.addString("GET / HTTP/1.0\r\n");
-        socket.addString("Connection: Keep-Alive\r\n\r\n");
+        socket.write("GET / HTTP/1.0\r\n");
+        socket.write("Connection: Keep-Alive\r\n\r\n");
       }
 
       List<int> response = [];
       int count = 0;
       socket.listen(
           (d) {
             response.addAll(d);
             if (response[response.length - 1] == "Z".codeUnitAt(0)) {
               String s = new String.fromCharCodes(response).toLowerCase();
               Expect.isTrue(s.indexOf("\r\nconnection: keep-alive\r\n") > 0);
@@ skipping 21 matching lines @@
 // server does not set a content length so it cannot honor connection
 // keep alive.
 void testHttp10KeepAliveServerCloses() {
   HttpServer.bind().then((server) {
     server.listen(
         (HttpRequest request) {
           Expect.isNull(request.headers.value('content-length'));
           Expect.equals(-1, request.contentLength);
           var response = request.response;
           Expect.equals("1.0", request.protocolVersion);
-          response.addString("Z");
+          response.write("Z");
           response.close();
         },
         onError: (e) => Expect.fail("Unexpected error $e"));
 
     int count = 0;
     makeRequest() {
       Socket.connect("127.0.0.1", server.port).then((socket) {
-        socket.addString("GET / HTTP/1.0\r\n");
-        socket.addString("Connection: Keep-Alive\r\n\r\n");
+        socket.write("GET / HTTP/1.0\r\n");
+        socket.write("Connection: Keep-Alive\r\n\r\n");
 
         List<int> response = [];
         socket.listen(
             response.addAll,
             onDone: () {
               socket.destroy();
               count++;
               String s = new String.fromCharCodes(response).toLowerCase();
               Expect.equals("z", s[s.length - 1]);
               Expect.equals(-1, s.indexOf("content-length"));
@@ skipping 11 matching lines @@
 }
 
 
 void main() {
   testHttp10NoKeepAlive();
   // TODO(8871): This test fails with short socket writes.
   //testHttp10ServerClose();
   testHttp10KeepAlive();
   testHttp10KeepAliveServerCloses();
 }