Make IOSink implement StringSink

sdk/lib/io/http.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart.io;
 
 /**
  * HTTP status codes.
  */
 abstract class HttpStatus {
@@ skipping 504 matching lines @@
 
   /**
    * Gets the sub type.
    */
   String get subType;
 
   /**
    * Gets the character set.
    */
   String get charset;
+
+  /**
+   * Returns the encoding based on the charset parameter. If no
+   * charset parameter is specified the default charset of ISO-8859-1
+   * will be assumed. If the charset cannot be matched with a
+   * supported encoding [:null:] is returned.
+   */
+  Encoding encoding;

[nweiz, 2013/03/06 20:31:51]

This seems like it's supposed to be read-only.

It's confusing that this and charset both exist at the same time, especially
since a programmer can't rely on [encoding] being non-null. It's also weird that
currently the only way to get an encoding from its string name is to instantiate
a ContentType and read its encoding.

I'd suggest adding an Encoding.fromName constructor and removing this field.

[Søren Gjesse, 2013/03/07 16:28:47]

Good point. Added static function fromName to Encoding and removed this.

 }
 
 
 /**
  * Representation of a cookie. For cookies received by the server as
  * Cookie header values only [:name:] and [:value:] fields will be
  * set. When building a cookie for the 'set-cookie' header in the server
  * and when receiving cookies in the client as 'set-cookie' headers all
  * fields can be used.
  */
@@ skipping 586 matching lines @@
 class RedirectLimitExceededException extends RedirectException {
   const RedirectLimitExceededException(List<RedirectInfo> redirects)
       : super("Redirect limit exceeded", redirects);
 }
 
 
 class RedirectLoopException extends RedirectException {
   const RedirectLoopException(List<RedirectInfo> redirects)
       : super("Redirect loop detected", redirects);
 }