Make IOSink implement StringSink

sdk/lib/io/file_impl.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart.io;
 
 
 class _FileStream extends Stream<List<int>> {
   // Stream controller.
   StreamController<List<int>> _controller;
@@ skipping 450 matching lines @@
   String fullPathSync() {
     var result = _fullPath(_path);
     throwIfError(result, "Cannot retrieve full path for file '$_path'");
     return result;
   }
 
   Stream<List<int>> openRead() {
     return new _FileStream(_path);
   }
 
-  IOSink<File> openWrite([FileMode mode = FileMode.WRITE]) {
+  IOSink<File> openWrite({FileMode mode: FileMode.WRITE,
+                          Encoding encoding: Encoding.UTF_8}) {
     if (mode != FileMode.WRITE &&
         mode != FileMode.APPEND) {
       throw new FileIOException(
           "Wrong FileMode. Use FileMode.WRITE or FileMode.APPEND");
     }
     var consumer = new _FileStreamConsumer(this, mode);
-    return new IOSink<File>(consumer);
+    return new IOSink<File>(consumer, encoding: encoding);
   }
 
   Future<List<int>> readAsBytes() {
     _ensureFileService();
     Completer<List<int>> completer = new Completer<List<int>>();
     var chunks = new _BufferList();
     openRead().listen(
       (d) => chunks.add(d),
       onDone: () {
         var result = chunks.readBytes(chunks.length);
@@ skipping 53 matching lines @@
   }
 
   List<String> readAsLinesSync([Encoding encoding = Encoding.UTF_8]) {
     return _decodeLines(readAsBytesSync(), encoding);
   }
 
   Future<File> writeAsBytes(List<int> bytes,
                             [FileMode mode = FileMode.WRITE]) {
     Completer<File> completer = new Completer<File>();
     try {
-      var stream = openWrite(mode);
-      stream.add(bytes);
-      stream.close();
-      stream.done
+      var sink = openWrite(mode: mode);
+      sink.writeBytes(bytes);
+      sink.close();
+      sink.done

[Anders Johnsen, 2013/03/07 16:53:49]

Maybe do:

- 'return sink.done ...' here
- Remove completer.
- In catch statement, do 'return new Future.immediateError(e);'

That way we avoid the extra completer.

[Søren Gjesse, 2013/03/08 09:47:46]

Thanks, that is mich nicer. Had to do

  return sink.done.then((_) => this);;

for the future to complete with the File object instead of the IOSink.

         .then((_) {
           completer.complete(this);
         })
         .catchError((e) {
           completer.completeError(e);
         });
     } catch (e) {
       Timer.run(() => completer.completeError(e));
       return completer.future;
     }
@@ skipping 483 matching lines @@
           new FileIOException("File closed '$_path'"));
     });
     return completer.future;
   }
 
   final String _path;
   int _id;
 
   SendPort _fileService;
 }