Make IOSink implement StringSink

pkg/http/lib/src/utils.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library utils;
 
 import 'dart:async';
 import 'dart:crypto';
 import 'dart:io';
 import 'dart:scalarlist';
@@ skipping 60 matching lines @@
     toSplit.substring(index + pattern.length)
   ];
 }
 
 /// Returns the [Encoding] that corresponds to [charset]. Returns [fallback] if
 /// [charset] is null or if no [Encoding] was found that corresponds to
 /// [charset].
 Encoding encodingForCharset(
     String charset, [Encoding fallback = Encoding.ISO_8859_1]) {
   if (charset == null) return fallback;
-  var encoding = _encodingForCharset(charset);
+  var encoding = Encoding.fromName(charset);
   return encoding == null ? fallback : encoding;
 }
 
-/// Returns the [Encoding] that corresponds to [charset]. Throws a
-/// [FormatException] if no [Encoding] was found that corresponds to [charset].
-/// [charset] may not be null.
-Encoding requiredEncodingForCharset(String charset) {

[nweiz, 2013/03/07 19:32:05]

Now I'm concerned that there are cases where [requiredEncodingFromCharset] was
being used that no longer throw FormatExceptions. Perhaps the right thing to do
is to leave it in after all and just implement it in terms of Encoding.fromName.

[Søren Gjesse, 2013/03/08 09:47:46]

Done.

-  var encoding = _encodingForCharset(charset);
-  if (encoding != null) return encoding;
-  throw new FormatException('Unsupported encoding "$charset".');
-}
-
-/// Returns the [Encoding] that corresponds to [charset]. Returns null if no
-/// [Encoding] was found that corresponds to [charset]. [charset] may not be
-/// null.
-Encoding _encodingForCharset(String charset) {
-  charset = charset.toLowerCase();
-  if (charset == 'ascii' || charset == 'us-ascii') return Encoding.ASCII;
-  if (charset == 'utf-8') return Encoding.UTF_8;
-  if (charset == 'iso-8859-1') return Encoding.ISO_8859_1;
-  return null;
-}
-
 /// Converts [bytes] into a [String] according to [encoding].
 String decodeString(List<int> bytes, Encoding encoding) {
   // TODO(nweiz): implement this once issue 6284 is fixed.
   return new String.fromCharCodes(bytes);
 }
 
 /// Converts [string] into a byte array according to [encoding].
 List<int> encodeString(String string, Encoding encoding) {
   // TODO(nweiz): implement this once issue 6284 is fixed.
   return string.codeUnits;
@@ skipping 128 matching lines @@
 /// The return values of all [Future]s are discarded. Any errors will cause the
 /// iteration to stop and will be piped through the return value.
 Future forEachFuture(Iterable input, Future fn(element)) {
   var iterator = input.iterator;
   Future nextElement(_) {
     if (!iterator.moveNext()) return new Future.immediate(null);
     return fn(iterator.current).then(nextElement);
   }
   return nextElement(null);
 }