Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1250383002: skia: wrong calling convention on eglGetPlatformDisplayEXT (Closed)

Created:
5 years, 5 months ago by hendrikw
Modified:
5 years, 5 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

skia: wrong calling convention on eglGetPlatformDisplayEXT When attempting to run the release compile of nanobench on windows, I would immediately crash due to c++'s buffer security check. This was caused by calling the function with the wrong calling convention. I'm not sure how this ever worked for anyone. Anyway, fix is to use eglext.h's version of the function definition. Committed: https://skia.googlesource.com/skia/+/266c232104e465f807cf57b2855836b250146a02

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M src/gpu/gl/angle/SkANGLEGLContext.cpp View 2 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
hendrikw
PTAL
5 years, 5 months ago (2015-07-24 02:30:37 UTC) #2
bsalomon
On 2015/07/24 02:30:37, hendrikw wrote: > PTAL lgtm
5 years, 5 months ago (2015-07-24 13:40:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1250383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1250383002/1
5 years, 5 months ago (2015-07-24 13:40:36 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-24 13:52:43 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/266c232104e465f807cf57b2855836b250146a02

Powered by Google App Engine
This is Rietveld 408576698