Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 1250323003: Vectorize profile badges in avatar menu (Closed)

Created:
5 years, 5 months ago by Evan Stade
Modified:
5 years, 4 months ago
Reviewers:
oshima, sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Vectorize profile badges in avatar menu BUG=505953 Committed: https://crrev.com/eaac88bb105113f414939a7902ba6fd59c565db9 Cr-Commit-Position: refs/heads/master@{#341149}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : self review #

Patch Set 4 : aa #

Total comments: 1

Patch Set 5 : self review #

Total comments: 1

Patch Set 6 : exclude resources #

Patch Set 7 : relative patchset #

Patch Set 8 : rebase #

Patch Set 9 : rebase #

Patch Set 10 : f is for float #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -42 lines) Patch
M chrome/app/theme/theme_resources.grd View 1 2 3 4 5 6 7 8 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/profiles/profile_chooser_view.cc View 1 2 3 4 5 6 7 3 chunks +53 lines, -4 lines 0 comments Download
M ui/gfx/BUILD.gn View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gfx/paint_vector_icon.cc View 1 2 3 4 5 6 7 3 chunks +33 lines, -33 lines 0 comments Download
A ui/gfx/vector_icons/account_child_invert.icon View 1 2 3 4 5 6 7 8 9 1 chunk +20 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/supervisor_account.icon View 1 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (13 generated)
Evan Stade
https://codereview.chromium.org/1250323003/diff/60001/chrome/browser/ui/views/profiles/profile_chooser_view.cc File chrome/browser/ui/views/profiles/profile_chooser_view.cc (right): https://codereview.chromium.org/1250323003/diff/60001/chrome/browser/ui/views/profiles/profile_chooser_view.cc#newcode484 chrome/browser/ui/views/profiles/profile_chooser_view.cc:484: class ProfileBadge : public gfx::CanvasImageSource { Depending on how ...
5 years, 5 months ago (2015-07-24 22:51:15 UTC) #2
sky
LGTM
5 years, 4 months ago (2015-07-27 15:11:44 UTC) #5
Evan Stade
+oshima for theme_resources.grd change
5 years, 4 months ago (2015-07-27 15:41:12 UTC) #9
oshima
lgtm
5 years, 4 months ago (2015-07-27 15:55:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1250323003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1250323003/120001
5 years, 4 months ago (2015-07-28 16:42:52 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/50057) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 4 months ago (2015-07-28 16:45:10 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1250323003/170007 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1250323003/170007
5 years, 4 months ago (2015-07-30 01:47:50 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/115417)
5 years, 4 months ago (2015-07-30 02:02:42 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1250323003/170007 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1250323003/170007
5 years, 4 months ago (2015-07-30 16:49:17 UTC) #22
commit-bot: I haz the power
Committed patchset #10 (id:170007)
5 years, 4 months ago (2015-07-30 17:29:48 UTC) #23
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 17:30:32 UTC) #24
Message was sent while issue was closed.
Patchset 10 (id:??) landed as
https://crrev.com/eaac88bb105113f414939a7902ba6fd59c565db9
Cr-Commit-Position: refs/heads/master@{#341149}

Powered by Google App Engine
This is Rietveld 408576698