runtime/vm/instructions_arm_test.cc - Issue 1250323002: Load immediates via the constant pool on armv5te and armv6.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/instructions_arm_test.cc

Issue 1250323002: Load immediates via the constant pool on armv5te and armv6. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: address comments Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/instructions_arm_test.cc

diff --git a/runtime/vm/instructions_arm_test.cc b/runtime/vm/instructions_arm_test.cc

index f3574acc8203162879345efae4f360577a69374a..0db757a13d54156255c7aa19bc26f18c3c1e0439 100644

--- a/runtime/vm/instructions_arm_test.cc

+++ b/runtime/vm/instructions_arm_test.cc

@@ -16,6 +16,8 @@ namespace dart {

#define __ assembler->

ASSEMBLER_TEST_GENERATE(Call, assembler) {

+ // Code accessing pp is generated, but not executed. Uninitialized pp is OK.

+ __ set_constant_pool_allowed(true);

__ BranchLinkPatchable(&StubCode::InvokeDartCodeLabel());

__ Ret();

}

« no previous file with comments | « runtime/vm/flow_graph_compiler_arm.cc ('k') | runtime/vm/intermediate_language_arm.cc » ('j') | no next file with comments »