runtime/vm/code_patcher_arm_test.cc - Issue 1250323002: Load immediates via the constant pool on armv5te and armv6.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/code_patcher_arm_test.cc

Issue 1250323002: Load immediates via the constant pool on armv5te and armv6. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/code_patcher_arm_test.cc

diff --git a/runtime/vm/code_patcher_arm_test.cc b/runtime/vm/code_patcher_arm_test.cc

index 9dfa92d8315933d0d5449da682de8c944dd1eae9..5f9653ca09b0ade71d27f095b41a0ccef2ac7995 100644

--- a/runtime/vm/code_patcher_arm_test.cc

+++ b/runtime/vm/code_patcher_arm_test.cc

@@ -39,6 +39,9 @@ ASSEMBLER_TEST_GENERATE(IcDataAccess, assembler) {

15,

1));

+ // Code accessing pp is generated, but not executed. Uninitialized pp is OK.

+ __ set_constant_pool_allowed(true);

__ LoadObject(R5, ic_data);

ExternalLabel target_label(StubCode::OneArgCheckInlineCacheEntryPoint());

__ BranchLinkPatchable(&target_label);