Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(826)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1250293002: fix path ops fuzz buster (Closed)

Created:
5 years, 5 months ago by caryclark
Modified:
5 years, 5 months ago
Reviewers:
f(malita)
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

fix path ops fuzz buster Mark collapsed segments as done and remove collapsed segment references from the coincidence array. Also add test names to global debugging. R=fmalita@chromium.org BUG=512592 Committed: https://skia.googlesource.com/skia/+/d4349723fac9c0fd4dcf8c275fb7c756bdfdff7b

Patch Set 1 #

Patch Set 2 : corrupting bug kaput #

Unified diffs Side-by-side diffs Delta from patch set Stats (+260 lines, -15 lines) Patch
M src/pathops/SkOpBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkOpCoincidence.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M src/pathops/SkOpContour.h View 1 chunk +9 lines, -0 lines 0 comments Download
M src/pathops/SkOpSegment.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/pathops/SkOpSegment.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M src/pathops/SkOpSpan.h View 2 chunks +5 lines, -0 lines 0 comments Download
M src/pathops/SkOpSpan.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M src/pathops/SkPathOpsCommon.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/pathops/SkPathOpsCommon.cpp View 3 chunks +9 lines, -1 line 0 comments Download
M src/pathops/SkPathOpsOp.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/pathops/SkPathOpsSimplify.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkPathOpsTightBounds.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkPathOpsTypes.h View 3 chunks +4 lines, -1 line 0 comments Download
M src/pathops/SkPathOpsTypes.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M tests/PathOpsAngleIdeas.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PathOpsAngleTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/PathOpsBuilderTest.cpp View 1 chunk +121 lines, -0 lines 0 comments Download
M tests/PathOpsExtendedTest.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M tests/PathOpsSimplifyTest.cpp View 1 1 chunk +65 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1250293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1250293002/1
5 years, 5 months ago (2015-07-23 18:52:17 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1250293002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1250293002/20001
5 years, 5 months ago (2015-07-23 18:59:07 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-23 19:21:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1250293002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1250293002/20001
5 years, 5 months ago (2015-07-23 19:23:13 UTC) #8
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 5 months ago (2015-07-23 19:23:14 UTC) #9
caryclark
Florin, I verified that this fixes the crash on Chrome ToT.
5 years, 5 months ago (2015-07-23 19:38:37 UTC) #10
f(malita)
On 2015/07/23 19:38:37, caryclark wrote: > Florin, I verified that this fixes the crash on ...
5 years, 5 months ago (2015-07-23 19:39:39 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/d4349723fac9c0fd4dcf8c275fb7c756bdfdff7b
5 years, 5 months ago (2015-07-23 19:40:27 UTC) #12
caryclark
5 years, 5 months ago (2015-07-23 19:48:08 UTC) #13
Message was sent while issue was closed. 
On 2015/07/23 19:39:39, f(malita) wrote:
> On 2015/07/23 19:38:37, caryclark wrote:
> > Florin, I verified that this fixes the crash on Chrome ToT.
> 
> Thanks, LGTM.
> 
> Is there any perf impact to be expected?

I don't think so -- I did add a non-recursive one-time visit to look for
collapsed edges. If this does show up on perf, I can add state to know whether
or not to look for collapsing.

I probably need to spend some cycles looking at perf though. Thanks for the
reminder!

Powered by Google App Engine
This is Rietveld 408576698