Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(891)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1250233002: Revert "Update Android Apps to use gradle" (Closed)

Created:
5 years, 5 months ago by joshua.litt
Modified:
5 years, 5 months ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert "Update Android Apps to use gradle" This reverts commit 425535f1626932e4e22f61a2571f9c3c2b1c5977. NOTRY=true NOTREECHECKS=true TBR=djsollen@google.com BUG=skia: DOCS_PREVIEW= https://skia.org/?cl=1250233002 Committed: https://skia.googlesource.com/skia/+/9efef7b56fef1c43c018f75c04b2b9e720f5bc2b

Patch Set 1 #

Patch Set 2 : presubmit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -2120 lines) Patch
M .gitignore View 2 chunks +0 lines, -7 lines 0 comments Download
A + platform_tools/android/app/AndroidManifest.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + platform_tools/android/app/build.xml View 2 chunks +2 lines, -33 lines 0 comments Download
A + platform_tools/android/app/jni/AndroidKeyToSkKey.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + platform_tools/android/app/jni/com_skia_SkiaSampleRenderer.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + platform_tools/android/app/jni/com_skia_SkiaSampleRenderer.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + platform_tools/android/app/project.properties View 1 chunk +1 line, -1 line 0 comments Download
A + platform_tools/android/app/res/drawable-hdpi/ic_btn_find_next.png View Binary file 0 comments Download
A + platform_tools/android/app/res/drawable-hdpi/ic_btn_find_prev.png View Binary file 0 comments Download
A + platform_tools/android/app/res/layout/layout.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + platform_tools/android/app/res/menu/action_bar.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + platform_tools/android/app/res/values/strings.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + platform_tools/android/app/src/com/skia/SkiaSampleActivity.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + platform_tools/android/app/src/com/skia/SkiaSampleRenderer.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + platform_tools/android/app/src/com/skia/SkiaSampleView.java View 0 chunks +-1 lines, --1 lines 0 comments Download
D platform_tools/android/apps/build.gradle View 1 chunk +0 lines, -86 lines 0 comments Download
D platform_tools/android/apps/sample_app/build.gradle View 1 chunk +0 lines, -46 lines 0 comments Download
D platform_tools/android/apps/sample_app/src/main/AndroidManifest.xml View 1 chunk +0 lines, -22 lines 0 comments Download
D platform_tools/android/apps/sample_app/src/main/java/com/skia/SkiaSampleActivity.java View 1 chunk +0 lines, -279 lines 0 comments Download
D platform_tools/android/apps/sample_app/src/main/java/com/skia/SkiaSampleRenderer.java View 1 chunk +0 lines, -113 lines 0 comments Download
D platform_tools/android/apps/sample_app/src/main/java/com/skia/SkiaSampleView.java View 1 chunk +0 lines, -306 lines 0 comments Download
D platform_tools/android/apps/sample_app/src/main/jni/AndroidKeyToSkKey.h View 1 chunk +0 lines, -35 lines 0 comments Download
D platform_tools/android/apps/sample_app/src/main/jni/com_skia_SkiaSampleRenderer.h View 1 chunk +0 lines, -164 lines 0 comments Download
D platform_tools/android/apps/sample_app/src/main/jni/com_skia_SkiaSampleRenderer.cpp View 1 chunk +0 lines, -384 lines 0 comments Download
D platform_tools/android/apps/sample_app/src/main/res/drawable-hdpi/ic_btn_find_next.png View Binary file 0 comments Download
D platform_tools/android/apps/sample_app/src/main/res/drawable-hdpi/ic_btn_find_prev.png View Binary file 0 comments Download
D platform_tools/android/apps/sample_app/src/main/res/layout/layout.xml View 1 chunk +0 lines, -17 lines 0 comments Download
D platform_tools/android/apps/sample_app/src/main/res/menu/action_bar.xml View 1 chunk +0 lines, -75 lines 0 comments Download
D platform_tools/android/apps/sample_app/src/main/res/values/strings.xml View 1 chunk +0 lines, -18 lines 0 comments Download
D platform_tools/android/apps/settings.gradle View 1 chunk +0 lines, -2 lines 0 comments Download
D platform_tools/android/apps/visualbench/build.gradle View 1 chunk +0 lines, -46 lines 0 comments Download
D platform_tools/android/apps/visualbench/src/main/AndroidManifest.xml View 1 chunk +0 lines, -29 lines 0 comments Download
D platform_tools/android/apps/visualbench/src/main/java/com/skia/VisualBenchActivity.java View 1 chunk +0 lines, -49 lines 0 comments Download
D platform_tools/android/apps/visualbench/src/main/jni/SkOSWindow_AndroidNative.cpp View 1 chunk +0 lines, -187 lines 0 comments Download
D platform_tools/android/apps/visualbench/src/main/jni/main.cpp View 1 chunk +0 lines, -134 lines 0 comments Download
M platform_tools/android/bin/android_install_app View 4 chunks +7 lines, -7 lines 0 comments Download
M platform_tools/android/bin/android_setup.sh View 1 chunk +0 lines, -5 lines 0 comments Download
M platform_tools/android/gyp/dependencies.gypi View 2 chunks +3 lines, -3 lines 0 comments Download
M platform_tools/android/gyp/skia_android.gypi View 5 chunks +50 lines, -27 lines 0 comments Download
A + platform_tools/android/visualbench/AndroidManifest.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + platform_tools/android/visualbench/build.xml View 2 chunks +2 lines, -33 lines 0 comments Download
A + platform_tools/android/visualbench/jni/SkOSWindow_AndroidNative.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + platform_tools/android/visualbench/jni/main.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + platform_tools/android/visualbench/project.properties View 1 chunk +1 line, -1 line 0 comments Download
A + platform_tools/android/visualbench/src/com/skia/VisualBenchActivity.java View 0 chunks +-1 lines, --1 lines 0 comments Download
M site/user/quick/android.md View 4 chunks +10 lines, -25 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1250233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1250233002/1
5 years, 5 months ago (2015-07-23 14:53:11 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/1273)
5 years, 5 months ago (2015-07-23 14:54:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1250233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1250233002/1
5 years, 5 months ago (2015-07-23 14:56:11 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/1275)
5 years, 5 months ago (2015-07-23 14:57:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1250233002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1250233002/20001
5 years, 5 months ago (2015-07-23 14:59:42 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-07-23 15:00:38 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/9efef7b56fef1c43c018f75c04b2b9e720f5bc2b

Powered by Google App Engine
This is Rietveld 408576698