Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1250223002: Remove readline support from d8. (Closed)

Created:
5 years, 5 months ago by Yang
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove readline support from d8. Nobody seems to use it. A good alternative is rlwrap. R=jochen@chromium.org Committed: https://crrev.com/8e027195b48a7e510ba48d67af68b880ab9cd6a9 Cr-Commit-Position: refs/heads/master@{#29810}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -293 lines) Patch
M BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M Makefile View 1 chunk +0 lines, -4 lines 0 comments Download
M src/d8.h View 2 chunks +0 lines, -22 lines 0 comments Download
M src/d8.cc View 6 chunks +8 lines, -61 lines 0 comments Download
M src/d8.gyp View 2 chunks +0 lines, -5 lines 0 comments Download
M src/d8.js View 1 chunk +0 lines, -45 lines 0 comments Download
D src/d8-readline.cc View 1 chunk +0 lines, -155 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Yang
5 years, 5 months ago (2015-07-23 12:54:16 UTC) #1
jochen (gone - plz use gerrit)
lgtm
5 years, 5 months ago (2015-07-23 12:56:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1250223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1250223002/1
5 years, 5 months ago (2015-07-23 12:57:10 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-23 13:20:19 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8e027195b48a7e510ba48d67af68b880ab9cd6a9 Cr-Commit-Position: refs/heads/master@{#29810}
5 years, 5 months ago (2015-07-23 13:20:40 UTC) #6
adamk
5 years, 5 months ago (2015-07-23 19:05:51 UTC) #8
Message was sent while issue was closed.
Please wait longer for responses before making changes like this in the future.

Powered by Google App Engine
This is Rietveld 408576698