Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 125021: Updates prior to cutting over chrome.dll to gyp generation:... (Closed)

Created:
11 years, 6 months ago by sgk
Modified:
9 years, 5 months ago
Reviewers:
bradnelson, bradn
CC:
chromium-reviews_googlegroups.com, Mark Mentovai
Visibility:
Public.

Description

Updates prior to cutting over chrome.dll to gyp generation: * Add dependency on the 'theme_dll' target, commented out to avoid a problem with default.lib not being generated. * Make the location of the generated chrome_dll_version.rc file consistent with other uses of SHARED_INTERMEDIATE_DIR. * Add the necessary generated *_resources.rc to 'sources'. * Remove 'process_outputs_as_sources' from the 'chrome_dll_version' action. It's now that it's in its own target. * Add settings from chrome\app\chrome_dll.vsprops. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18254

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -4 lines) Patch
M chrome/chrome.gyp View 1 2 7 chunks +27 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sgk
This doesn't convert chrome.dll to gyp generation. There's still some setting or dependency issue that's ...
11 years, 6 months ago (2009-06-12 05:03:01 UTC) #1
sgk
TBR=bradnelson Updated. Commented out the theme_dll dependency because it causes the same problem with default.lib ...
11 years, 6 months ago (2009-06-12 06:20:25 UTC) #2
bradn
11 years, 6 months ago (2009-06-12 18:06:18 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698