Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 12502025: Add test for Khronos Group license and whitelist it. (Closed)

Created:
7 years, 9 months ago by Raymond Toy (Google)
Modified:
7 years, 9 months ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add test for Khronos Group license and whitelist it. BUG= TBR=brettw@chromium.org,cpu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190741

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M third_party/devscripts/licensecheck.pl View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M tools/checklicenses/checklicenses.py View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Paweł Hajdan Jr.
https://codereview.chromium.org/12502025/diff/1/third_party/devscripts/licensecheck.pl File third_party/devscripts/licensecheck.pl (right): https://codereview.chromium.org/12502025/diff/1/third_party/devscripts/licensecheck.pl#newcode580 third_party/devscripts/licensecheck.pl:580: if ($licensetext =~ /The Khronos Group Inc. All Rights ...
7 years, 9 months ago (2013-03-25 18:29:45 UTC) #1
Raymond Toy (Google)
On 2013/03/25 18:29:45, Paweł Hajdan Jr. wrote: > https://codereview.chromium.org/12502025/diff/1/third_party/devscripts/licensecheck.pl > File third_party/devscripts/licensecheck.pl (right): > > ...
7 years, 9 months ago (2013-03-25 21:49:54 UTC) #2
Paweł Hajdan Jr.
LGTM
7 years, 9 months ago (2013-03-25 21:52:20 UTC) #3
Raymond Toy (Google)
+brettw, +cpu Please review.
7 years, 9 months ago (2013-03-25 22:02:12 UTC) #4
brettw
LGTM
7 years, 9 months ago (2013-03-25 23:46:02 UTC) #5
Raymond Toy (Google)
On 2013/03/25 23:46:02, brettw wrote: > LGTM Thanks everyone.
7 years, 9 months ago (2013-03-26 16:18:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtoy@google.com/12502025/6001
7 years, 9 months ago (2013-03-26 16:20:35 UTC) #7
commit-bot: I haz the power
7 years, 9 months ago (2013-03-26 19:47:40 UTC) #8
Message was sent while issue was closed.
Change committed as 190741

Powered by Google App Engine
This is Rietveld 408576698