Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3155)

Unified Diff: chrome/browser/signin/signin_manager_factory.h

Issue 12502017: signin: pull basic SigninManager functionality into new SigninManagerBase class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: deal with new enterprise_platform_keys_private_api Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/signin/signin_manager_factory.h
diff --git a/chrome/browser/signin/signin_manager_factory.h b/chrome/browser/signin/signin_manager_factory.h
index 7cb2b81f3f4d34ee9e3b4632b2e2d6a1b4a71594..4df297f8b8bb32994705da295c595df7b392cdc3 100644
--- a/chrome/browser/signin/signin_manager_factory.h
+++ b/chrome/browser/signin/signin_manager_factory.h
@@ -9,6 +9,7 @@
#include "chrome/browser/profiles/profile_keyed_service_factory.h"
class SigninManager;
+class SigninManagerBase;
class PrefRegistrySimple;
class PrefRegistrySyncable;
class Profile;
@@ -18,15 +19,23 @@ class Profile;
// the associated SigninManager.
class SigninManagerFactory : public ProfileKeyedServiceFactory {
public:
+
+#if defined(OS_CHROMEOS)
// Returns the instance of SigninManager associated with this profile
// (creating one if none exists). Returns NULL if this profile cannot have a
// SigninManager (for example, if |profile| is incognito).
- static SigninManager* GetForProfile(Profile* profile);
+ static SigninManagerBase* GetForProfile(Profile* profile);
// Returns the instance of SigninManager associated with this profile. Returns
// null if no SigninManager instance currently exists (will not create a new
// instance).
+ static SigninManagerBase* GetForProfileIfExists(Profile* profile);
+#else
+ // On non-ChromeOS platforms, the SigninManager the factory creates will be
+ // an instance of the extended SigninManager class.
+ static SigninManager* GetForProfile(Profile* profile);
static SigninManager* GetForProfileIfExists(Profile* profile);
+#endif
// Returns an instance of the SigninManagerFactory singleton.
static SigninManagerFactory* GetInstance();
« no previous file with comments | « chrome/browser/signin/signin_manager_base_unittest.cc ('k') | chrome/browser/signin/signin_manager_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698