chrome/browser/chromeos/login/screen_locker.cc - Issue 12502017: signin: pull basic SigninManager functionality into new SigninManagerBase class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/screen_locker.cc

Issue 12502017: signin: pull basic SigninManager functionality into new SigninManagerBase class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: deal with new enterprise_platform_keys_private_api Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/login_utils.cc ('k') | chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/screen_locker.cc

diff --git a/chrome/browser/chromeos/login/screen_locker.cc b/chrome/browser/chromeos/login/screen_locker.cc

index 1ed42df8046785a30e9ab3e06596db1f05325aad..853d62152916106f70cd07a07a754d5ed18e5435 100644

--- a/chrome/browser/chromeos/login/screen_locker.cc

+++ b/chrome/browser/chromeos/login/screen_locker.cc

@@ -200,7 +200,7 @@ void ScreenLocker::OnLoginSuccess(

if (profile && !user_context.password.empty()) {

// We have a non-empty password, so notify listeners (such as the sync

// engine).

- SigninManager* signin = SigninManagerFactory::GetForProfile(profile);

+ SigninManagerBase* signin = SigninManagerFactory::GetForProfile(profile);

DCHECK(signin);

GoogleServiceSigninSuccessDetails details(

signin->GetAuthenticatedUsername(),