chrome/browser/sync/profile_sync_service_session_unittest.cc - Issue 12502017: signin: pull basic SigninManager functionality into new SigninManagerBase class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/profile_sync_service_session_unittest.cc

Issue 12502017: signin: pull basic SigninManager functionality into new SigninManagerBase class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix override Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/signin/signin_manager_base.h ('K') | « chrome/browser/sync/profile_sync_service_preference_unittest.cc ('k') | chrome/browser/sync/profile_sync_service_startup_unittest.cc » ('j') | chrome/browser/sync/profile_sync_service_startup_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/profile_sync_service_session_unittest.cc

diff --git a/chrome/browser/sync/profile_sync_service_session_unittest.cc b/chrome/browser/sync/profile_sync_service_session_unittest.cc

index 1ee92a6ec5a72ecf2869a11c4c88495fa1e41795..aec4a09d27be38bc179796620a2c79c018c110bd 100644

--- a/chrome/browser/sync/profile_sync_service_session_unittest.cc

+++ b/chrome/browser/sync/profile_sync_service_session_unittest.cc

@@ -74,7 +74,7 @@ class FakeProfileSyncService : public TestProfileSyncService {

FakeProfileSyncService(

ProfileSyncComponentsFactory* factory,

Profile* profile,

- SigninManager* signin,

+ SigninManagerBase* signin,

ProfileSyncService::StartBehavior behavior,

bool synchronous_backend_initialization)

: TestProfileSyncService(factory,

@@ -259,7 +259,8 @@ class ProfileSyncServiceSessionTest

bool will_fail_association) {

if (sync_service_.get())

return false;

- SigninManager* signin = SigninManagerFactory::GetForProfile(profile());

+ SigninManagerBase* signin =

+ SigninManagerFactory::GetForProfile(profile());

signin->SetAuthenticatedUsername("test_user");

ProfileSyncComponentsFactoryMock* factory =

new ProfileSyncComponentsFactoryMock();