chrome/browser/sync/profile_sync_service_password_unittest.cc - Issue 12502017: signin: pull basic SigninManager functionality into new SigninManagerBase class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/profile_sync_service_password_unittest.cc

Issue 12502017: signin: pull basic SigninManager functionality into new SigninManagerBase class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix override Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/signin/signin_manager_base.h ('K') | « chrome/browser/sync/profile_sync_service_harness.cc ('k') | chrome/browser/sync/profile_sync_service_preference_unittest.cc » ('j') | chrome/browser/sync/profile_sync_service_startup_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/profile_sync_service_password_unittest.cc

diff --git a/chrome/browser/sync/profile_sync_service_password_unittest.cc b/chrome/browser/sync/profile_sync_service_password_unittest.cc

index bf839be8f8db88eeb339d24d951e1ea103b54f61..7f1a9da6f7edd4d342b3096afca7ab0198bd5e35 100644

--- a/chrome/browser/sync/profile_sync_service_password_unittest.cc

+++ b/chrome/browser/sync/profile_sync_service_password_unittest.cc

@@ -98,7 +98,7 @@ class PasswordTestProfileSyncService : public TestProfileSyncService {

PasswordTestProfileSyncService(

ProfileSyncComponentsFactory* factory,

Profile* profile,

- SigninManager* signin)

+ SigninManagerBase* signin)

: TestProfileSyncService(factory,

profile,

signin,

@@ -129,7 +129,8 @@ class PasswordTestProfileSyncService : public TestProfileSyncService {

}

static ProfileKeyedService* Build(Profile* profile) {

- SigninManager* signin = SigninManagerFactory::GetForProfile(profile);

+ SigninManagerBase* signin =

+ SigninManagerFactory::GetForProfile(profile);

ProfileSyncComponentsFactoryMock* factory =

new ProfileSyncComponentsFactoryMock();

return new PasswordTestProfileSyncService(factory, profile, signin);

@@ -198,7 +199,8 @@ class ProfileSyncServicePasswordTest : public AbstractProfileSyncServiceTest {

void StartSyncService(const base::Closure& root_callback,

const base::Closure& node_callback) {

if (!sync_service_) {

- SigninManager* signin = SigninManagerFactory::GetForProfile(&profile_);

+ SigninManagerBase* signin =

+ SigninManagerFactory::GetForProfile(&profile_);

signin->SetAuthenticatedUsername("test_user");

token_service_ = static_cast<TokenService*>(

TokenServiceFactory::GetInstance()->SetTestingFactoryAndUse(