chrome/browser/sync/profile_sync_service.cc - Issue 12502017: signin: pull basic SigninManager functionality into new SigninManagerBase class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/profile_sync_service.cc

Issue 12502017: signin: pull basic SigninManager functionality into new SigninManagerBase class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix override Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/signin/signin_manager_base.h ('K') | « chrome/browser/sync/profile_sync_service.h ('k') | chrome/browser/sync/profile_sync_service_autofill_unittest.cc » ('j') | chrome/browser/sync/profile_sync_service_startup_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/profile_sync_service.cc

diff --git a/chrome/browser/sync/profile_sync_service.cc b/chrome/browser/sync/profile_sync_service.cc

index 35e56815da9350f3c406241f5f7ac9ec3d30c901..79f02bb159044a2b1351ab731dae00ee4c8c8ca7 100644

--- a/chrome/browser/sync/profile_sync_service.cc

+++ b/chrome/browser/sync/profile_sync_service.cc

@@ -130,7 +130,7 @@ bool ShouldShowActionOnUI(

ProfileSyncService::ProfileSyncService(ProfileSyncComponentsFactory* factory,

Profile* profile,

- SigninManager* signin_manager,

+ SigninManagerBase* signin_manager,

StartBehavior start_behavior)

: last_auth_error_(AuthError::AuthErrorNone()),

passphrase_required_reason_(syncer::REASON_PASSPHRASE_NOT_REQUIRED),

@@ -2014,7 +2014,7 @@ void ProfileSyncService::UpdateInvalidatorRegistrarState() {

void ProfileSyncService::ResetForTest() {

Profile* profile = profile_;

- SigninManager* signin = SigninManagerFactory::GetForProfile(profile);

+ SigninManagerBase* signin = SigninManagerFactory::GetForProfile(profile);

ProfileSyncService::StartBehavior behavior =

browser_defaults::kSyncAutoStarts ? ProfileSyncService::AUTO_START

: ProfileSyncService::MANUAL_START;