Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Unified Diff: chrome/browser/signin/signin_manager_unittest.cc

Issue 12502017: signin: pull basic SigninManager functionality into new SigninManagerBase class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix override Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/signin/signin_manager_unittest.cc
diff --git a/chrome/browser/signin/signin_manager_unittest.cc b/chrome/browser/signin/signin_manager_unittest.cc
index 79964d01bab1e0c719ad40d81ae2c2ade008f419..10f881aacfd4de1fdd04aca52f846148fb6fb0b9 100644
--- a/chrome/browser/signin/signin_manager_unittest.cc
+++ b/chrome/browser/signin/signin_manager_unittest.cc
@@ -332,51 +332,6 @@ TEST_F(SigninManagerTest, SignInClientLogin) {
EXPECT_EQ("user@gmail.com", manager_->GetAuthenticatedUsername());
}
-TEST_F(SigninManagerTest, Prohibited) {
- g_browser_process->local_state()->SetString(
- prefs::kGoogleServicesUsernamePattern, ".*@google.com");
- manager_->Initialize(profile_.get());
- EXPECT_TRUE(manager_->IsAllowedUsername("test@google.com"));
- EXPECT_TRUE(manager_->IsAllowedUsername("happy@google.com"));
- EXPECT_FALSE(manager_->IsAllowedUsername("test@invalid.com"));
- EXPECT_FALSE(manager_->IsAllowedUsername("test@notgoogle.com"));
- EXPECT_FALSE(manager_->IsAllowedUsername(""));
-}
-
-TEST_F(SigninManagerTest, TestAlternateWildcard) {
- // Test to make sure we accept "*@google.com" as a pattern (treat it as if
- // the admin entered ".*@google.com").
- g_browser_process->local_state()->SetString(
- prefs::kGoogleServicesUsernamePattern, "*@google.com");
- manager_->Initialize(profile_.get());
- EXPECT_TRUE(manager_->IsAllowedUsername("test@google.com"));
- EXPECT_TRUE(manager_->IsAllowedUsername("happy@google.com"));
- EXPECT_FALSE(manager_->IsAllowedUsername("test@invalid.com"));
- EXPECT_FALSE(manager_->IsAllowedUsername("test@notgoogle.com"));
- EXPECT_FALSE(manager_->IsAllowedUsername(""));
-}
-
-TEST_F(SigninManagerTest, ProhibitedAtStartup) {
- profile_->GetPrefs()->SetString(prefs::kGoogleServicesUsername,
- "monkey@invalid.com");
- g_browser_process->local_state()->SetString(
- prefs::kGoogleServicesUsernamePattern, ".*@google.com");
- manager_->Initialize(profile_.get());
- // Currently signed in user is prohibited by policy, so should be signed out.
- EXPECT_EQ("", manager_->GetAuthenticatedUsername());
-}
-
-TEST_F(SigninManagerTest, ProhibitedAfterStartup) {
- std::string user("monkey@invalid.com");
- profile_->GetPrefs()->SetString(prefs::kGoogleServicesUsername, user);
- manager_->Initialize(profile_.get());
- EXPECT_EQ(user, manager_->GetAuthenticatedUsername());
- // Update the profile - user should be signed out.
- g_browser_process->local_state()->SetString(
- prefs::kGoogleServicesUsernamePattern, ".*@google.com");
- EXPECT_EQ("", manager_->GetAuthenticatedUsername());
-}
-
TEST_F(SigninManagerTest, SignInWithCredentials) {
manager_->Initialize(profile_.get());
EXPECT_TRUE(manager_->GetAuthenticatedUsername().empty());

Powered by Google App Engine
This is Rietveld 408576698