Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3289)

Unified Diff: chrome/browser/signin/signin_manager_factory.cc

Issue 12502017: signin: pull basic SigninManager functionality into new SigninManagerBase class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix override Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/signin/signin_manager_factory.cc
diff --git a/chrome/browser/signin/signin_manager_factory.cc b/chrome/browser/signin/signin_manager_factory.cc
index 67e33c07dc9b7ec18e4c4ee86afd54ac215918b8..0d0ab4c5f370b3298463a05c1cc8814ed853801f 100644
--- a/chrome/browser/signin/signin_manager_factory.cc
+++ b/chrome/browser/signin/signin_manager_factory.cc
@@ -21,6 +21,22 @@ SigninManagerFactory::SigninManagerFactory()
SigninManagerFactory::~SigninManagerFactory() {}
+#if defined(OS_CHROMEOS)
+// static
+SigninManagerBase* SigninManagerFactory::GetForProfileIfExists(
+ Profile* profile) {
+ return static_cast<SigninManagerBase*>(
+ GetInstance()->GetServiceForProfile(profile, false));
+}
+
+// static
+SigninManagerBase* SigninManagerFactory::GetForProfile(
+ Profile* profile) {
+ return static_cast<SigninManagerBase*>(
+ GetInstance()->GetServiceForProfile(profile, true));
+}
+
+#else
// static
SigninManager* SigninManagerFactory::GetForProfile(Profile* profile) {
return static_cast<SigninManager*>(
@@ -32,6 +48,7 @@ SigninManager* SigninManagerFactory::GetForProfileIfExists(Profile* profile) {
return static_cast<SigninManager*>(
GetInstance()->GetServiceForProfile(profile, false));
}
+#endif
// static
SigninManagerFactory* SigninManagerFactory::GetInstance() {
@@ -59,7 +76,14 @@ void SigninManagerFactory::RegisterPrefs(PrefRegistrySimple* registry) {
ProfileKeyedService* SigninManagerFactory::BuildServiceInstanceFor(
Profile* profile) const {
- SigninManager* service = new SigninManager();
+
+ SigninManagerBase* service = NULL;
+#if defined(OS_CHROMEOS)
+ service = new SigninManagerBase();
+#else
+ service = new SigninManager();
+#endif
+
service->Initialize(profile);
return service;
}

Powered by Google App Engine
This is Rietveld 408576698