chrome/browser/chromeos/login/login_utils.cc - Issue 12502017: signin: pull basic SigninManager functionality into new SigninManagerBase class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/login_utils.cc

Issue 12502017: signin: pull basic SigninManager functionality into new SigninManagerBase class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix override Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chrome_content_browser_client.cc ('k') | chrome/browser/chromeos/login/screen_locker.cc » ('j') | chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/login_utils.cc

diff --git a/chrome/browser/chromeos/login/login_utils.cc b/chrome/browser/chromeos/login/login_utils.cc

index 35b7b06e2cb3cc787ab6100f543ec0f39f6d0b27..48a65f3f4ad031ca32318f3904a9481d4c524e18 100644

--- a/chrome/browser/chromeos/login/login_utils.cc

+++ b/chrome/browser/chromeos/login/login_utils.cc

@@ -637,9 +637,10 @@ void LoginUtilsImpl::InitRlz(Profile* user_profile, bool disabled) {

void LoginUtilsImpl::StartSignedInServices(Profile* user_profile) {

// Fetch/Create the SigninManager - this will cause the TokenService to load

- // tokens for the currently signed-in user if the SigninManager hasn't already

- // been initialized.

- SigninManager* signin = SigninManagerFactory::GetForProfile(user_profile);

+ // tokens for the currently signed-in user if the SigninManager hasn't

+ // already been initialized.

+ SigninManagerBase* signin =

+ SigninManagerFactory::GetForProfile(user_profile);

DCHECK(signin);

// Make sure SigninManager is connected to our current user (this should

// happen automatically because we set kGoogleServicesUsername in