signin: pull basic SigninManager functionality into new SigninManagerBase class.

chrome/browser/policy/url_blacklist_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/policy/url_blacklist_manager.h"
 
 #include "base/bind.h"
 #include "base/message_loop.h"
 #include "base/prefs/pref_service.h"
 #include "base/stl_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/values.h"
 #include "chrome/browser/net/url_fixer_upper.h"
-#include "chrome/browser/signin/signin_manager.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/pref_names.h"
 #include "components/user_prefs/pref_registry_syncable.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/notification_details.h"
 #include "content/public/browser/notification_source.h"
 #include "google_apis/gaia/gaia_urls.h"
 #include "googleurl/src/gurl.h"
 #include "net/base/load_flags.h"
 #include "net/url_request/url_request.h"
 
+#if !defined(OS_CHROMEOS)
+#include "chrome/browser/signin/signin_manager.h"
+#endif
+
 using content::BrowserThread;
 using extensions::URLMatcher;
 using extensions::URLMatcherCondition;
 using extensions::URLMatcherConditionFactory;
 using extensions::URLMatcherConditionSet;
 using extensions::URLMatcherPortFilter;
 using extensions::URLMatcherSchemeFilter;
 
 namespace policy {
 
@@ skipping 16 matching lines @@
 
 bool IsStandardScheme(const std::string& scheme) {
   for (size_t i = 0; i < arraysize(kStandardSchemes); ++i) {
     if (scheme == kStandardSchemes[i])
       return true;
   }
   return false;
 }
 
 bool IsSigninFlowURL(const GURL& url) {
+#if !defined(OS_CHROMEOS)
   // Whitelist all the signin flow URLs flagged by the SigninManager.
   if (SigninManager::IsWebBasedSigninFlowURL(url))
     return true;
+#endif

[Roger Tawa OOO till Jul 10th, 2013/04/05 20:53:57]

Strange to ifdef out only this part.  Is this function needed at all in cros?

[tim (not reviewing), 2013/04/05 22:14:12]

I'm not sure.  CrOS still has a signin flow of its own, I don't know if this had
an impact, so for now I left it intact.  

Perhaps a c/b/policy OWNER can check this (atwilson?)

[Joao da Silva, 2013/04/09 15:26:07]

This function is only used in this file (it's in the anonymous namespace) and
can be #ifdef'd away when !defined(OS_CHROMEOS). It's only called from line 390,
which will also need an #ifdef.

The blacklist only applies to the profile's request context, and ChromeOS signin
uses the system request context, so this has no impact at all on that.

[Andrew T Wilson (Slow), 2013/04/09 15:39:25]

Good question. I've asked joao to check.

[tim (not reviewing), 2013/04/16 03:28:29]

Done.

[tim (not reviewing), 2013/04/16 03:28:29]

Done.

 
   // Additionally whitelist /ServiceLoginAuth.
   if (url.GetOrigin() != GURL(GaiaUrls::GetInstance()->gaia_origin_url()))
     return false;
   return url.path() == kServiceLoginAuth;
 }
 
 // A task that builds the blacklist on the FILE thread.
 scoped_ptr<URLBlacklist> BuildBlacklist(scoped_ptr<base::ListValue> block,
                                         scoped_ptr<base::ListValue> allow) {
@@ skipping 314 matching lines @@
 
 // static
 void URLBlacklistManager::RegisterUserPrefs(PrefRegistrySyncable* registry) {
   registry->RegisterListPref(prefs::kUrlBlacklist,
                              PrefRegistrySyncable::UNSYNCABLE_PREF);
   registry->RegisterListPref(prefs::kUrlWhitelist,
                              PrefRegistrySyncable::UNSYNCABLE_PREF);
 }
 
 }  // namespace policy