Adding a "Learn more" link to the Google DNS selection

Adding a "Learn more" link to the Google DNS selection
on the static IP configuration page in network settings.

Also, adjust the size of the dialog so that custom DNS fields don't
cause scrolling.

BUG=chromium:172634
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190053

[stevenjb, 2013-03-20 00:22:11]

I'm not especially familiar with html/css, but lgtm
+pneubeck@

[pneubeck (no reviews), 2013-03-20 09:09:02]

https://codereview.chromium.org/12502012/diff/1/chrome/app/chromeos_strings.grdp
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/12502012/diff/1/chrome/app/chromeos_strings.g...
chrome/app/chromeos_strings.grdp:1211: Google name servers - <ph
name="BEGIN_LINK">&lt;a href="https://developers.google.com/speed/public-dns"
target="_blank"&gt;</ph>Learn more<ph
name="END_LINK">&lt;/a&gt;<ex>&lt;/a&gt;</ex></ph>
you don't have an example for the first <ph>
better make it consistent and drop it from the second <ph> too.

Alternative which I prefer:
make only the "Learn more" translatable with another <message>
Would be much more readable and wouldn't "misuse" the <ph>.

[Greg Spencer (Chromium), 2013-03-20 17:31:02]

https://codereview.chromium.org/12502012/diff/1/chrome/app/chromeos_strings.grdp
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/12502012/diff/1/chrome/app/chromeos_strings.g...
chrome/app/chromeos_strings.grdp:1211: Google name servers - <ph
name="BEGIN_LINK">&lt;a href="https://developers.google.com/speed/public-dns"
target="_blank"&gt;</ph>Learn more<ph
name="END_LINK">&lt;/a&gt;<ex>&lt;/a&gt;</ex></ph>
On 2013/03/20 09:09:02, pneubeck wrote:
> you don't have an example for the first <ph>
> better make it consistent and drop it from the second <ph> too.

Good point, done.  The <ex> was pretty useless there anyhow.
> 
> Alternative which I prefer:
> make only the "Learn more" translatable with another <message>
> Would be much more readable and wouldn't "misuse" the <ph>.

Well, but I don't want to do that because another language might make it hard to
substitute that.  The surrounding text might have to be a vague tense or gender
or something to account for the fact that the substituted message might contain
anything.  I'd rather have the entire string in one message so that the
translators get the entire context at once.

[pneubeck (no reviews), 2013-03-21 10:24:56]

lgtm

[commit-bot: I haz the power, 2013-03-21 16:56:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gspencer@chromium.org/12502012/6001

[commit-bot: I haz the power, 2013-03-22 18:18:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gspencer@chromium.org/12502012/6001

[commit-bot: I haz the power, 2013-03-23 14:55:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gspencer@chromium.org/12502012/6001

[commit-bot: I haz the power, 2013-03-23 18:25:09]

Change committed as 190053